Merge pull request #81285 from eeckstein/fix-false-error-in-sourcekit

embedded: avoid false error "Deinit of non-copyable type not visible in the current module" in SourceKit

Author: eeckstein

SwiftCompilerSources/Sources/Optimizer/ModulePasses/MandatoryPerformanceOptimizations.swift

@@ -151,11 +151,17 @@ private func optimize(function: Function, _ context: FunctionPassContext, _ modu
       // We need to de-virtualize deinits of non-copyable types to be able to specialize the deinitializers.
       case let destroyValue as DestroyValueInst:
         if !devirtualizeDeinits(of: destroyValue, simplifyCtxt) {
-          context.diagnosticEngine.diagnose(.deinit_not_visible, at: destroyValue.location)
+          // If invoked from SourceKit avoid reporting false positives when WMO is turned off for indexing purposes.
+          if moduleContext.enableWMORequiredDiagnostics {
+            context.diagnosticEngine.diagnose(.deinit_not_visible, at: destroyValue.location)
+          }
         }
       case let destroyAddr as DestroyAddrInst:
         if !devirtualizeDeinits(of: destroyAddr, simplifyCtxt) {
-          context.diagnosticEngine.diagnose(.deinit_not_visible, at: destroyAddr.location)
+          // If invoked from SourceKit avoid reporting false positives when WMO is turned off for indexing purposes.
+          if moduleContext.enableWMORequiredDiagnostics {
+            context.diagnosticEngine.diagnose(.deinit_not_visible, at: destroyAddr.location)
+          }
         }
 
       case let iem as InitExistentialMetatypeInst:

test/SourceKit/Diagnostics/embedded_non_wmo.swift

@@ -16,6 +16,11 @@ func foo() {
     bar(Int.self)
 }
 
+func testNonCopyable() {
+  let nc = NonCopyable()
+  nc.doSomething()
+}
+
 @main
 struct Main {
     var someClass = SomeClass()
@@ -31,6 +36,11 @@ final class SomeClass {}
 
 func bar<T>(_ T: T.Type) {}
 
+struct NonCopyable : ~Copyable {
+  func doSomething() {}
+  deinit {}
+}
+
 // CHECK:      {
 // CHECK-NEXT:   key.diagnostics: [
 // CHECK-NEXT:   ]