Skip to content

[Sema] Fix compiler error when extending a typealias of a partially specialized generic type #73169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 50 commits into
base: main
Choose a base branch
from
Open

[Sema] Fix compiler error when extending a typealias of a partially specialized generic type #73169

wants to merge 50 commits into from

Conversation

xavgru12
Copy link

@xavgru12 xavgru12 commented Apr 21, 2024 •
edited
Loading

Resolves #68212.

@AnthonyLatsis
Copy link
Collaborator

@swift-ci please smoke test Linux

@saehejkang
Copy link
Contributor

saehejkang commented Apr 21, 2024 •
edited
Loading

i was curious to see how this was solved and guess I was overcomplicating the issue 😭

@AnthonyLatsis
Copy link
Collaborator

This is far from solved, FWIW 🙂. I only triggered the tests to encourage the author to iterate on failures before any feedback arrives.

@xedin
Copy link
Contributor

xedin commented Apr 24, 2024

Is it possible to make this PR as a draft?

@AnthonyLatsis AnthonyLatsis marked this pull request as draft April 24, 2024 20:59
@xavgru12
Copy link
Author

I was converting to draft but Anthony was faster

@AnthonyLatsis
Copy link
Collaborator

For posterity, the convert to draft button is at the bottom of the Reviewers section.

@AnthonyLatsis AnthonyLatsis self-requested a review April 26, 2024 21:19
@AnthonyLatsis AnthonyLatsis self-assigned this Jan 27, 2025
@xavgru12 xavgru12 mentioned this pull request Mar 9, 2025
Open
@xavgru12 xavgru12 closed this Mar 10, 2025
@xavgru12 xavgru12 deleted the genericTypealias branch March 10, 2025 17:26
@xavgru12 xavgru12 reopened this Mar 10, 2025
@xavgru12 xavgru12 marked this pull request as ready for review March 31, 2025 18:31
@xavgru12 xavgru12 closed this Mar 31, 2025
@xavgru12 xavgru12 restored the genericTypealias branch March 31, 2025 18:32
@xavgru12 xavgru12 reopened this Mar 31, 2025
@xavgru12
Copy link
Author

deleted and pushed branch in order to trigger CI

@xavgru12
Copy link
Author

xavgru12 commented Apr 2, 2025

@AnthonyLatsis check this out

@xavgru12
Copy link
Author

xavgru12 commented Apr 3, 2025 •
edited
Loading

merged main again, smoke test Linux was green already

@xavgru12
Copy link
Author

xavgru12 commented Apr 9, 2025

@AnthonyLatsis I see you have been quite busy with 6.1 these days. Could you review this?

@xavgru12 xavgru12 changed the title Compiler error when extending a typealias of a partially specialized generic type #68212 Fix compiler error when extending a typealias of a partially specialized generic type #68212 Apr 11, 2025
@xavgru12 xavgru12 changed the title Fix compiler error when extending a typealias of a partially specialized generic type #68212 Fix compiler error when extending a typealias of a partially specialized generic type Apr 11, 2025
@xavgru12 xavgru12 changed the title Fix compiler error when extending a typealias of a partially specialized generic type [Sema] Fix compiler error when extending a typealias of a partially specialized generic type Apr 12, 2025
@AnthonyLatsis
Copy link
Collaborator

@swift-ci please smoke test macOS

@AnthonyLatsis
Copy link
Collaborator

Will have a review ready by Monday.

AnthonyLatsis
AnthonyLatsis reviewed Apr 15, 2025
View reviewed changes
Copy link
Collaborator

@AnthonyLatsis AnthonyLatsis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall direction is looking great!

Please add regression tests with extensions for all the type alias examples from my comments as you go.

@xavgru12
Copy link
Author

xavgru12 commented May 4, 2025

@AnthonyLatsis
I changed the code according review and added test cases. Let me know what you think about this.

@xavgru12 xavgru12 requested a review from AnthonyLatsis May 4, 2025 20:42
@xavgru12
Copy link
Author

@AnthonyLatsis reminder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

@AnthonyLatsis AnthonyLatsis Awaiting requested review from AnthonyLatsis

Assignees

@AnthonyLatsis AnthonyLatsis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compiler error when extending a typealias of a partially specialized generic type
4 participants
@xavgru12 @AnthonyLatsis @saehejkang @xedin