Skip to content

Commit 71f2932

Browse files
authored
Disable attachment test until attachments are formally released (#1412)
Attachments are still SPI, and SPI is available on linux and windows but not through Xcode on macOS. We can reenable this once attachments are formalized and no longer SPI.
1 parent 5753b6b commit 71f2932

File tree

2 files changed

+12
-15
lines changed

2 files changed

+12
-15
lines changed

assets/test/defaultPackage/Tests/PackageTests/PackageTests.swift

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -42,13 +42,9 @@ final class DebugReleaseTestSuite: XCTestCase {
4242
}
4343
}
4444

45-
#if swift(>=6.1)
46-
@_spi(Experimental) import Testing
47-
#elseif swift(>=6.0)
45+
#if swift(>=6.0)
4846
import Testing
49-
#endif
5047

51-
#if swift(>=6.0)
5248
@Test func topLevelTestPassing() {
5349
print("A print statement in a test.")
5450
#if !TEST_ARGUMENT_SET_VIA_TEST_BUILD_ARGUMENTS_SETTING
@@ -112,11 +108,12 @@ struct MixedSwiftTestingSuite {
112108
}
113109
#endif
114110

115-
#if swift(>=6.1)
116-
@Test func testAttachment() throws {
117-
Attachment("Hello, world!", named: "hello.txt").attach()
118-
}
119-
#endif
111+
// Disabled until Attachments are formalized and released.
112+
// #if swift(>=6.1)
113+
// @Test func testAttachment() throws {
114+
// Attachment("Hello, world!", named: "hello.txt").attach()
115+
// }
116+
// #endif
120117

121118
final class DuplicateSuffixTests: XCTestCase {
122119
func testPassing() throws {}

test/integration-tests/testexplorer/TestExplorerIntegration.test.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,6 @@ suite("Test Explorer Suite", function () {
192192
"testWithKnownIssue()",
193193
"testWithKnownIssueAndUnknownIssue()",
194194
"testLotsOfOutput()",
195-
"testAttachment()",
196195
"DuplicateSuffixTests",
197196
["testPassing()", "testPassingSuffix()"],
198197
],
@@ -255,7 +254,8 @@ suite("Test Explorer Suite", function () {
255254
);
256255
});
257256

258-
test("attachments", async function () {
257+
// Disabled until Attachments are formalized and released.
258+
test.skip("attachments", async function () {
259259
// Attachments were introduced in 6.1
260260
if (workspaceContext.swiftVersion.isLessThan(new Version(6, 1, 0))) {
261261
this.skip();
@@ -624,8 +624,8 @@ suite("Test Explorer Suite", function () {
624624

625625
assertTestResults(testRun, {
626626
passed: [
627-
`${testId}/PackageTests.swift:63:2/argumentIDs: Optional([Testing.Test.Case.Argument.ID(bytes: [49])])`,
628-
`${testId}/PackageTests.swift:63:2/argumentIDs: Optional([Testing.Test.Case.Argument.ID(bytes: [51])])`,
627+
`${testId}/PackageTests.swift:59:2/argumentIDs: Optional([Testing.Test.Case.Argument.ID(bytes: [49])])`,
628+
`${testId}/PackageTests.swift:59:2/argumentIDs: Optional([Testing.Test.Case.Argument.ID(bytes: [51])])`,
629629
],
630630
failed: [
631631
{
@@ -635,7 +635,7 @@ suite("Test Explorer Suite", function () {
635635
text: "Expectation failed: (arg → 2) != 2",
636636
})}`,
637637
],
638-
test: `${testId}/PackageTests.swift:63:2/argumentIDs: Optional([Testing.Test.Case.Argument.ID(bytes: [50])])`,
638+
test: `${testId}/PackageTests.swift:59:2/argumentIDs: Optional([Testing.Test.Case.Argument.ID(bytes: [50])])`,
639639
},
640640
{
641641
issues: [],

0 commit comments

Comments
 (0)