bug #45981 [Serializer][PropertyInfo] Fix support for "false" built-in type on PHP 8.2 (alexandre-daubois)

This PR was merged into the 4.4 branch.

Discussion
----------

[Serializer][PropertyInfo] Fix support for "false" built-in type on PHP 8.2

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes (new language feature support)
| New feature?  | no
| Deprecations? | no
| Tickets       | _NA_
| License       | MIT
| Doc PR        | _NA_

`false` and `null` built-in types have been merged in PHP 8.2 a few hours ago: php/php-src#7546 🎉
RFC: https://wiki.php.net/rfc/null-false-standalone-types

PropertyInfo and Serializer both need an update to support them.

Commits
-------

4187d3fddd [Serializer][PropertyInfo] Fix support for "false" built-in type on PHP 8.2

Author: nicolas-grekas

Normalizer/AbstractObjectNormalizer.php

@@ -483,7 +483,7 @@ private function validateAndDenormalize(string $currentClass, string $attribute,
                     return (float) $data;
                 }
 
-                if (('is_'.$builtinType)($data)) {
+                if ('false' === $builtinType || ('is_'.$builtinType)($data)) {
                     return $data;
                 }
             } catch (NotNormalizableValueException $e) {

Tests/Fixtures/FalseBuiltInDummy.php

@@ -0,0 +1,17 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\Serializer\Tests\Fixtures;
+
+class FalseBuiltInDummy
+{
+    public false $false = false;
+}

Tests/SerializerTest.php

@@ -51,6 +51,7 @@
 use Symfony\Component\Serializer\Tests\Fixtures\DummyMessageInterface;
 use Symfony\Component\Serializer\Tests\Fixtures\DummyMessageNumberOne;
 use Symfony\Component\Serializer\Tests\Fixtures\DummyMessageNumberTwo;
+use Symfony\Component\Serializer\Tests\Fixtures\FalseBuiltInDummy;
 use Symfony\Component\Serializer\Tests\Fixtures\NormalizableTraversableDummy;
 use Symfony\Component\Serializer\Tests\Fixtures\TraversableDummy;
 use Symfony\Component\Serializer\Tests\Normalizer\TestDenormalizer;
@@ -572,6 +573,19 @@ public function testUnionTypeDeserializable()
         $this->assertEquals(new DummyUnionType(), $actual, 'Union type denormalization third case failed.');
     }
 
+    /**
+     * @requires PHP 8.2
+     */
+    public function testFalseBuiltInTypes()
+    {
+        $extractor = new PropertyInfoExtractor([], [new ReflectionExtractor()]);
+        $serializer = new Serializer([new ObjectNormalizer(null, null, null, $extractor)], ['json' => new JsonEncoder()]);
+
+        $actual = $serializer->deserialize('{"false":false}', FalseBuiltInDummy::class, 'json');
+
+        $this->assertEquals(new FalseBuiltInDummy(), $actual);
+    }
+
     private function serializerWithClassDiscriminator()
     {
         $classMetadataFactory = new ClassMetadataFactory(new AnnotationLoader(new AnnotationReader()));