Skip to content

Commit 0eb5f89

Browse files
committed
minor #19028 Doctor RST ensure link definitions bottom (alamirault)
This PR was merged into the 5.4 branch. Discussion ---------- Doctor RST ensure link definitions bottom Ensure link definitions are at the bottom of file `@OskarStark` Commits ------- bcd944a Doctor RST ensure link definitions bottom
2 parents c6f0310 + bcd944a commit 0eb5f89

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

.doctor-rst.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ rules:
1414
ensure_bash_prompt_before_composer_command: ~
1515
ensure_exactly_one_space_before_directive_type: ~
1616
ensure_exactly_one_space_between_link_definition_and_link: ~
17+
ensure_link_bottom: ~
1718
ensure_link_definition_contains_valid_url: ~
1819
ensure_order_of_code_blocks_in_configuration_block: ~
1920
ensure_php_reference_syntax: ~

contributing/code/conventions.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,8 +181,6 @@ after the use declarations, like in this example from `ServiceRouterLoader`_::
181181
*/
182182
class ServiceRouterLoader extends ObjectRouteLoader
183183

184-
.. _`ServiceRouterLoader`: https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Routing/Loader/DependencyInjection/ServiceRouterLoader.php
185-
186184
The deprecation must be added to the ``CHANGELOG.md`` file of the impacted component:
187185

188186
.. code-block:: markdown
@@ -239,3 +237,5 @@ Commands and their options should be named and described using the English
239237
imperative mood (i.e. 'run' instead of 'runs', 'list' instead of 'lists'). Using
240238
the imperative mood is concise and consistent with similar command-line
241239
interfaces (such as Unix man pages).
240+
241+
.. _`ServiceRouterLoader`: https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Routing/Loader/DependencyInjection/ServiceRouterLoader.php

frontend/encore/faq.rst

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -137,8 +137,6 @@ For performance, Encore does not process libraries inside ``node_modules/`` thro
137137
Babel. But, you can change that via the ``configureBabel()`` method. See
138138
:doc:`/frontend/encore/babel` for details.
139139

140-
.. _`rsync`: https://rsync.samba.org/
141-
142140
How Do I Integrate my Encore Configuration with my IDE?
143141
-------------------------------------------------------
144142

@@ -168,8 +166,6 @@ running it (e.g. when executing ``yarn encore dev``). Fix this issue calling to
168166
169167
// ... the rest of the Encore configuration
170168
171-
.. _`Webpack integration in PhpStorm`: https://www.jetbrains.com/help/phpstorm/using-webpack.html
172-
173169
My Tests are Failing Because of ``entrypoints.json`` File
174170
---------------------------------------------------------
175171

@@ -194,3 +190,6 @@ functions to trigger exceptions when there's no ``entrypoints.json`` file):
194190
webpack_encore:
195191
strict_mode: false
196192
# ...
193+
194+
.. _`rsync`: https://rsync.samba.org/
195+
.. _`Webpack integration in PhpStorm`: https://www.jetbrains.com/help/phpstorm/using-webpack.html

0 commit comments

Comments
 (0)