Skip to content

Commit 25a6e7a

Browse files
committed
minor #7391 Fix missing key for time-sensitive tests (z38)
This PR was merged into the 2.8 branch. Discussion ---------- Fix missing key for time-sensitive tests The Symfony test listener [prints a warning](https://github.com/symfony/symfony/blob/4491eb64633f1945537e8a6a07adbb3ef5c1f802/src/Symfony/Bridge/PhpUnit/SymfonyTestsListener.php#L66) when numeric keys are used to configure mocked namespaces. As the specification of multiple namespaces might be a bit intuitive (I can't add multiple `<element key="time-sensitive">`), maybe the following example would be better: ```xml <listener class="Symfony\Bridge\PhpUnit\SymfonyTestsListener"> <arguments> <array> <element key="time-sensitive"> <array> <element><string>Symfony\Component\HttpFoundation</string></element> </array> </element> </array> </arguments> </listener> ``` Commits ------- 1d1c58b Fix missing key for time-sensitive tests
2 parents d6efc43 + 1d1c58b commit 25a6e7a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

components/phpunit_bridge.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,7 @@ the mocked namespaces in the ``phpunit.xml`` file, as done for example in the
232232
<listener class="Symfony\Bridge\PhpUnit\SymfonyTestsListener">
233233
<arguments>
234234
<array>
235-
<element><string>Symfony\Component\HttpFoundation</string></element>
235+
<element key="time-sensitive"><string>Symfony\Component\HttpFoundation</string></element>
236236
</array>
237237
</arguments>
238238
</listener>

0 commit comments

Comments
 (0)