Updated the session/* articles for Symfony 4

Author: javiereguiluz

session.rst

@@ -3,6 +3,11 @@ Sessions
 
 .. toctree::
     :maxdepth: 1
-    :glob:
 
-    session/*
+    session/sessions_directory
+    session/avoid_session_start
+    session/locale_sticky_session
+    session/limit_metadata_writes
+    session/php_bridge
+    session/proxy_examples
+

session/limit_metadata_writes.rst

@@ -23,12 +23,14 @@ than zero:
 
     .. code-block:: yaml
 
+        # config/packages/framework.yaml
         framework:
             session:
                 metadata_update_threshold: 120
 
     .. code-block:: xml
 
+        <!-- config/packages/framework.xml -->
         <?xml version="1.0" encoding="UTF-8" ?>
         <container xmlns="http://symfony.com/schema/dic/services"
             xmlns:framework="http://symfony.com/schema/dic/symfony"
@@ -45,6 +47,7 @@ than zero:
 
     .. code-block:: php
 
+        // config/packages/framework.php
         $container->loadFromExtension('framework', array(
             'session' => array(
                 'metadata_update_threshold' => 120,

session/locale_sticky_session.rst

@@ -73,16 +73,18 @@ via some "Change Locale" route & controller), or create a route with a the :ref:
 
         .. code-block:: yaml
 
+            # config/services.yaml
             services:
                 # ...
 
                 App\EventSubscriber\LocaleSubscriber:
                     arguments: ['%kernel.default_locale%']
-                    # redundant if you're using autoconfigure
-                    tags: [kernel.event_subscriber]
+                    # uncomment the next line if you are not using autoconfigure
+                    # tags: [kernel.event_subscriber]
 
         .. code-block:: xml
 
+            <!-- config/services.xml -->
             <?xml version="1.0" encoding="UTF-8" ?>
             <container xmlns="http://symfony.com/schema/dic/services"
                 xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
@@ -93,18 +95,21 @@ via some "Change Locale" route & controller), or create a route with a the :ref:
                     <service id="App\EventSubscriber\LocaleSubscriber">
                         <argument>%kernel.default_locale%</argument>
 
-                        <tag name="kernel.event_subscriber" />
+                        <!-- uncomment the next line if you are not using autoconfigure -->
+                        <!-- <tag name="kernel.event_subscriber" /> -->
                     </service>
                 </services>
             </container>
 
         .. code-block:: php
 
+            // config/services.php
             use App\EventSubscriber\LocaleSubscriber;
 
             $container->register(LocaleSubscriber::class)
                 ->addArgument('%kernel.default_locale%')
-                ->addTag('kernel.event_subscriber');
+                // uncomment the next line if you are not using autoconfigure
+                // ->addTag('kernel.event_subscriber');
 
 That's it! Now celebrate by changing the user's locale and seeing that it's
 sticky throughout the request.
@@ -115,7 +120,7 @@ method::
     // from a controller...
     use Symfony\Component\HttpFoundation\Request;
 
-    public function indexAction(Request $request)
+    public function index(Request $request)
     {
         $locale = $request->getLocale();
     }
@@ -159,9 +164,6 @@ event:
             $this->session = $session;
         }
 
-        /**
-         * @param InteractiveLoginEvent $event
-         */
         public function onInteractiveLogin(InteractiveLoginEvent $event)
         {
             $user = $event->getAuthenticationToken()->getUser();

session/php_bridge.rst

@@ -15,13 +15,15 @@ for the ``handler_id``:
 
     .. code-block:: yaml
 
+        # config/packages/framework.yaml
         framework:
             session:
                 storage_id: session.storage.php_bridge
                 handler_id: ~
 
     .. code-block:: xml
 
+        <!-- config/packages/framework.xml -->
         <?xml version="1.0" encoding="UTF-8" ?>
         <container xmlns="http://symfony.com/schema/dic/services"
             xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
@@ -38,6 +40,7 @@ for the ``handler_id``:
 
     .. code-block:: php
 
+        // config/packages/framework.php
         $container->loadFromExtension('framework', array(
             'session' => array(
                 'storage_id' => 'session.storage.php_bridge',
@@ -54,13 +57,15 @@ the example below:
 
     .. code-block:: yaml
 
+        # config/packages/framework.yaml
         framework:
             session:
                 storage_id: session.storage.php_bridge
                 handler_id: session.handler.native_file
 
     .. code-block:: xml
 
+        <!-- config/packages/framework.xml -->
         <?xml version="1.0" encoding="UTF-8" ?>
         <container xmlns="http://symfony.com/schema/dic/services"
             xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
@@ -77,6 +82,7 @@ the example below:
 
     .. code-block:: php
 
+        // config/packages/framework.php
         $container->loadFromExtension('framework', array(
             'session' => array(
                 'storage_id' => 'session.storage.php_bridge',

session/proxy_examples.rst

@@ -21,15 +21,15 @@ Symfony to use your session handler instead of the default one:
 
     .. code-block:: yaml
 
-        # app/config/config.yml
+        # config/packages/framework.yaml
         framework:
             session:
                 # ...
                 handler_id: App\Session\CustomSessionHandler
 
     .. code-block:: xml
 
-        <!-- app/config/config.xml -->
+        <!-- config/packages/framework.xml -->
         <?xml version="1.0" encoding="UTF-8" ?>
         <container xmlns="http://symfony.com/schema/dic/services"
             xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
@@ -44,7 +44,7 @@ Symfony to use your session handler instead of the default one:
 
     .. code-block:: php
 
-        // app/config/config.php
+        // config/packages/framework.php
         use App\Session\CustomSessionHandler;
         $container->loadFromExtension('framework', array(
             // ...

session/sessions_directory.rst

@@ -11,15 +11,15 @@ this path, update the ``framework.session.save_path`` configuration key:
 
     .. code-block:: yaml
 
-        # app/config/config.yml
+        # config/packages/framework.yaml
         framework:
             session:
                 handler_id: session.handler.native_file
                 save_path: '%kernel.project_dir%/var/sessions/%kernel.environment%'
 
     .. code-block:: xml
 
-        <!-- app/config/config.xml -->
+        <!-- config/packages/framework.xml -->
         <?xml version="1.0" encoding="UTF-8" ?>
         <container xmlns="http://symfony.com/schema/dic/services"
             xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
@@ -36,7 +36,7 @@ this path, update the ``framework.session.save_path`` configuration key:
 
     .. code-block:: php
 
-        // app/config/config.php
+        // config/packages/framework.php
         $container->loadFromExtension('framework', array(
             'session' => array(
                 'handler_id' => 'session.handler.native_file',