Skip to content

Commit ca91121

Browse files
committed
Merge branch '3.3' into 3.4
* 3.3: Removed some unneeded white spaces Fixed a typo in templating/debug.rst Mention the SensioGeneratorBundle in the bundles article Use stricter syntax when testing Fix default value of strict_variables minor #9042 add missing twig dump construct (hellomedia, javiereguiluz)
2 parents 762d26a + 0387f3b commit ca91121

File tree

5 files changed

+17
-19
lines changed

5 files changed

+17
-19
lines changed

bundles.rst

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -70,17 +70,14 @@ are used by your application (including the core Symfony bundles).
7070
Creating a Bundle
7171
-----------------
7272

73-
The Symfony Standard Edition comes with a handy task that creates a fully-functional
74-
bundle for you. Of course, creating a bundle by hand is pretty easy as well.
73+
`SensioGeneratorBundle`_ is an optional bundle that includes commands to create
74+
different elements of your application, such as bundles. If you create lots of
75+
bundles, consider using it. However, this section creates and enables a new
76+
bundle by hand to show how simple is to do it.
7577

76-
To show you how simple the bundle system is, create a new bundle called
77-
AcmeTestBundle and enable it.
78-
79-
.. tip::
80-
81-
The ``Acme`` portion is just a dummy name that should be replaced by
82-
some "vendor" name that represents you or your organization (e.g.
83-
ABCTestBundle for some company named ``ABC``).
78+
The new bundle is called AcmeTestBundle, where the ``Acme`` portion is just a
79+
dummy name that should be replaced by some "vendor" name that represents you or
80+
your organization (e.g. ABCTestBundle for some company named ``ABC``).
8481

8582
Start by creating a ``src/Acme/TestBundle/`` directory and adding a new file
8683
called ``AcmeTestBundle.php``::
@@ -188,3 +185,4 @@ Learn more
188185
bundles/*
189186

190187
.. _`third-party bundles`: https://github.com/search?q=topic%3Asymfony-bundle&type=Repositories
188+
.. _`SensioGeneratorBundle`: https://github.com/sensiolabs/SensioGeneratorBundle

components/asset.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -204,10 +204,10 @@ class can take into account the context of the current request::
204204
new StaticVersionStrategy('v1'),
205205
new RequestStackContext($requestStack)
206206
);
207-
207+
208208
echo $package->getUrl('logo.png');
209209
// result: /somewhere/static/images/logo.png?v1
210-
210+
211211
// Both "base path" and "base url" are ignored when using absolute path for asset
212212
echo $package->getUrl('/logo.png');
213213
// result: /logo.png?v1

email/testing.rst

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,17 +47,17 @@ to get information about the messages sent on the previous request::
4747
$mailCollector = $client->getProfile()->getCollector('swiftmailer');
4848

4949
// Check that an email was sent
50-
$this->assertEquals(1, $mailCollector->getMessageCount());
50+
$this->assertSame(1, $mailCollector->getMessageCount());
5151

5252
$collectedMessages = $mailCollector->getMessages();
5353
$message = $collectedMessages[0];
5454

5555
// Asserting email data
5656
$this->assertInstanceOf('Swift_Message', $message);
57-
$this->assertEquals('Hello Email', $message->getSubject());
58-
$this->assertEquals('[email protected]', key($message->getFrom()));
59-
$this->assertEquals('[email protected]', key($message->getTo()));
60-
$this->assertEquals(
57+
$this->assertSame('Hello Email', $message->getSubject());
58+
$this->assertSame('[email protected]', key($message->getFrom()));
59+
$this->assertSame('[email protected]', key($message->getTo()));
60+
$this->assertSame(
6161
'You should see me from the profiler!',
6262
$message->getBody()
6363
);

reference/configuration/twig.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -459,7 +459,7 @@ by Symfony. Besides, it simplifies how you refer to those templates:
459459
strict_variables
460460
~~~~~~~~~~~~~~~~
461461

462-
**type**: ``boolean`` **default**: ``'%kernel.debug%'``
462+
**type**: ``boolean`` **default**: ``false``
463463

464464
If set to ``true``, Symfony shows an exception whenever a Twig variable,
465465
attribute or method doesn't exist. If set to ``false`` these errors are ignored

templating/debug.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ In a Twig template, you can use the ``dump`` utility as a function or a tag:
4949
{% dump articles %}
5050

5151
{% for article in articles %}
52-
{# the contents of this variable are display on the web page #}
52+
{# the contents of this variable are displayed on the web page #}
5353
{{ dump(article) }}
5454

5555
<a href="/article/{{ article.slug }}">

0 commit comments

Comments
 (0)