Skip to content

Commit 5a86aad

Browse files
committed
minor #144 Specify PHPUnit versions (Nyholm)
This PR was merged into the main branch. Discussion ---------- Specify PHPUnit versions This will make the PHP8 test pass. Commits ------- 5f3c8d0 Specify PHPUnit version in CI
2 parents 401e277 + 5f3c8d0 commit 5a86aad

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

.github/workflows/ci.yml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,15 @@ jobs:
1515
run:
1616
- php: '7.4'
1717
sf_version: '4.4.*'
18+
phpunit_version: '9.4'
1819
- php: '8.0'
1920
sf_version: '5.3.*'
21+
phpunit_version: '9.4'
2022
- php: '7.1'
21-
sf_version: '*'
2223
- php: '7.2'
23-
sf_version: '*'
2424
- php: '7.3'
25-
sf_version: '*'
2625
- php: '7.4'
27-
sf_version: '*'
26+
phpunit_version: '9.4'
2827

2928
steps:
3029
- name: Set up PHP
@@ -39,10 +38,12 @@ jobs:
3938

4039
- name: Download dependencies
4140
env:
42-
SYMFONY_REQUIRE: ${{ matrix.run.sf_version }}
41+
SYMFONY_REQUIRE: ${{ matrix.run.sf_version || '*' }}
4342
uses: ramsey/composer-install@v1
4443

4544
- name: Run tests
45+
env:
46+
SYMFONY_PHPUNIT_VERSION: ${{ matrix.run.phpunit_version || '' }}
4647
run: ./vendor/bin/simple-phpunit
4748

4849
lowest:
@@ -66,4 +67,5 @@ jobs:
6667
- name: Run tests
6768
env:
6869
SYMFONY_DEPRECATIONS_HELPER: "max[self]=0"
70+
SYMFONY_PHPUNIT_VERSION: "8.5"
6971
run: ./vendor/bin/simple-phpunit

0 commit comments

Comments
 (0)