Change to match CommonMark

* remark now complies to CommonMark, this means that we can adhere too,
  and prefer the first if duplicate definitions are found.
  Previously, this was an option and defaulted to `false`.
  It’s no longer possible to change the behavior of this utility.

Author: wooorm

index.js

@@ -12,27 +12,23 @@ function getDefinitionFactory(node, options) {
 }
 
 // Gather all definitions in `node`
-function gather(node, options) {
+function gather(node) {
   var cache = {}
 
   if (!node || !node.type) {
     throw new Error('mdast-util-definitions expected node')
   }
 
-  visit(node, 'definition', options && options.commonmark ? commonmark : normal)
+  visit(node, 'definition', ondefinition)
 
   return cache
 
-  function commonmark(definition) {
+  function ondefinition(definition) {
     var id = normalise(definition.identifier)
     if (!own.call(cache, id)) {
       cache[id] = definition
     }
   }
-
-  function normal(definition) {
-    cache[normalise(definition.identifier)] = definition
-  }
 }
 
 // Factory to get a node from the given definition-cache.

readme.md

@@ -45,15 +45,12 @@ definition('foo')
 
 ## API
 
-### `definitions(node[, options])`
+### `definitions(tree)`
 
-Create a cache of all [definition][]s in [`node`][node].
+Create a cache of all [definition][]s in [`tree`][node].
 
-###### `options.commonmark`
-
-`boolean`, default: false — Turn on (`true`) to use CommonMark precedence:
-ignore definitions found later for duplicate definitions.
-The default behavior is to prefer the last found definition.
+Uses CommonMark precedence: prefers the first definitions for duplicate
+definitions.
 
 ###### Returns
 

test.js

@@ -73,14 +73,8 @@ test('mdast-util-definitions', function (t) {
 
   t.deepEqual(
     definitions(tree)('example').url,
-    'https://two.com',
-    'should prefer the last of duplicate definitions by default'
-  )
-
-  t.deepEqual(
-    definitions(tree, {commonmark: true})('example').url,
     'https://one.com',
-    'should prefer the first of duplicate definitions in commonmark mode'
+    'should prefer the first of duplicate definitions'
   )
 
   t.end()

types/index.d.ts

@@ -3,15 +3,6 @@ import {Node} from 'unist'
 import {Definition} from 'mdast'
 
 declare namespace definitions {
-  interface Options {
-    /**
-     * Turn on (`true`) to use CommonMark precedence: ignore definitions found later for duplicate definitions. The default behavior is to prefer the last found definition.
-     *
-     * @default false
-     */
-    commonmark: boolean
-  }
-
   /**
    * @param identifier [Identifier](https://github.com/syntax-tree/mdast#association) of [definition](https://github.com/syntax-tree/mdast#definition).
    */
@@ -21,9 +12,6 @@ declare namespace definitions {
 /**
  * Create a cache of all [definition](https://github.com/syntax-tree/mdast#definition)s in [`node`](https://github.com/syntax-tree/unist#node).
  */
-declare function definitions(
-  node: Node,
-  options?: definitions.Options
-): definitions.DefinitionCache
+declare function definitions(node: Node): definitions.DefinitionCache
 
 export = definitions