Skip to content

Commit 11b2b98

Browse files
authored
fix(ethernet): move event listener earlier to avoid missing event ETH_CONNECTED
1 parent 039d92a commit 11b2b98

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

libraries/Ethernet/src/ETH.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -175,6 +175,8 @@ bool ETHClass::begin(eth_phy_type_t type, int32_t phy_addr, int mdc, int mdio, i
175175
return false;
176176
}
177177

178+
Network.onSysEvent(onEthConnected, ARDUINO_EVENT_ETH_CONNECTED);
179+
178180
eth_esp32_emac_config_t mac_config = ETH_ESP32_EMAC_DEFAULT_CONFIG();
179181
mac_config.clock_config.rmii.clock_mode = (clock_mode) ? EMAC_CLK_OUT : EMAC_CLK_EXT_IN;
180182
mac_config.clock_config.rmii.clock_gpio = (1 == clock_mode) ? EMAC_APPL_CLK_OUT_GPIO : (2 == clock_mode) ? EMAC_CLK_OUT_GPIO : (3 == clock_mode) ? EMAC_CLK_OUT_180_GPIO : EMAC_CLK_IN_GPIO;
@@ -226,7 +228,7 @@ bool ETHClass::begin(eth_phy_type_t type, int32_t phy_addr, int mdc, int mdio, i
226228
case ETH_PHY_DP83848:
227229
phy = esp_eth_phy_new_dp83848(&phy_config);
228230
break;
229-
case ETH_PHY_JL1101:
231+
case ETH_PHY_JL1101:
230232
phy = esp_eth_phy_new_jl1101(&phy_config);
231233
break;
232234
case ETH_PHY_KSZ8041:
@@ -311,8 +313,6 @@ bool ETHClass::begin(eth_phy_type_t type, int32_t phy_addr, int mdc, int mdio, i
311313
if(!perimanSetPinBus(_pin_power, ESP32_BUS_TYPE_ETHERNET_PWR, (void *)(this), -1, -1)){ goto err; }
312314
}
313315

314-
Network.onSysEvent(onEthConnected, ARDUINO_EVENT_ETH_CONNECTED);
315-
316316
// holds a few milliseconds to let DHCP start and enter into a good state
317317
// FIX ME -- adresses issue https://github.com/espressif/arduino-esp32/issues/5733
318318
delay(50);

0 commit comments

Comments
 (0)