Skip to content

Commit 28fc87d

Browse files
committed
Do not use --no-install-project.
1 parent 74812d0 commit 28fc87d

File tree

5 files changed

+15
-15
lines changed

5 files changed

+15
-15
lines changed

.github/workflows/build-binaries.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -49,11 +49,11 @@ jobs:
4949
# https://github.com/python-poetry/poetry/issues/7611 and
5050
# https://github.com/python-poetry/poetry/pull/7694 are fixed
5151
- run: python -m pip install --upgrade wheel "poetry==1.3.2" poethepoet
52-
- run: uv sync --no-install-project --all-extras
52+
- run: uv sync --all-extras
5353

5454
# Add the source dist only for Linux x64 for now
5555
- if: ${{ matrix.package-suffix == 'linux-amd64' }}
56-
run: poetry build --format sdist
56+
run: uv build --sdist
5757

5858
# Build and fix the wheel
5959
- run: uv run cibuildwheel --output-dir dist

.github/workflows/ci.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ jobs:
4848
repo-token: ${{ secrets.GITHUB_TOKEN }}
4949
- uses: astral-sh/setup-uv@v5
5050
- run: python -m pip install --upgrade wheel poethepoet
51-
- run: uv sync --no-install-project --all-extras
51+
- run: uv sync --all-extras
5252
- run: poe bridge-lint
5353
if: ${{ matrix.clippyLinter }}
5454
- run: poe lint
@@ -84,7 +84,7 @@ jobs:
8484
TEMPORAL_TEST_PROTO3: 1
8585
run: |
8686
uv add --python 3.9 "protobuf<4"
87-
uv sync --no-install-project --all-extras
87+
uv sync --all-extras
8888
poe gen-protos
8989
poe format
9090
[[ -z $(git status --porcelain temporalio) ]] || (git diff temporalio; echo "Protos changed"; exit 1)

.github/workflows/run-bench.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ jobs:
4747
- uses: astral-sh/setup-uv@v5
4848
# Build
4949
- run: python -m pip install --upgrade wheel poethepoet
50-
- run: uv sync --no-install-project --all-extras
50+
- run: uv sync --all-extras
5151
- run: poe build-develop-with-release
5252

5353
# Run a bunch of bench tests. We run multiple times since results vary.

README.md

+9-9
Original file line numberDiff line numberDiff line change
@@ -1406,10 +1406,10 @@ git clone --recursive https://github.com/temporalio/sdk-python.git
14061406
cd sdk-python
14071407
```
14081408

1409-
Install the dependencies (`--no-install-project` because we will build it in the next step):
1409+
Install the dependencies:
14101410

14111411
```bash
1412-
uv sync --no-install-project --all-extras
1412+
uv sync --all-extras
14131413
```
14141414

14151415
#### Build
@@ -1420,7 +1420,7 @@ Now perform the release build:
14201420
environment](#local-sdk-development-environment) for the quicker approach to local development).
14211421

14221422
```bash
1423-
poetry build
1423+
uv build
14241424
```
14251425

14261426
The compiled wheel doesn't have the exact right tags yet for use, so run this script to fix it:
@@ -1493,7 +1493,7 @@ installing dependencies:
14931493
```bash
14941494
git clone --recursive https://github.com/temporalio/sdk-python.git
14951495
cd sdk-python
1496-
uv sync --no-install-project --all-extras
1496+
uv sync --all-extras
14971497
```
14981498

14991499
Now compile the Rust extension in develop mode which is quicker than release mode:
@@ -1526,12 +1526,12 @@ poe test -s --log-cli-level=DEBUG -k test_sync_activity_thread_cancel_caught
15261526
#### Proto Generation and Testing
15271527

15281528
To allow for backwards compatibility, protobuf code is generated on the 3.x series of the protobuf library. To generate
1529-
protobuf code, you must be on Python <= 3.10, and then run `uv add "protobuf<4"` +
1530-
`uv sync --no-install-project --all-extras`. Then the protobuf files can be generated via `poe gen-protos`. Tests can be run
1531-
for protobuf version 3 by setting the `TEMPORAL_TEST_PROTO3` env var to `1` prior to running tests.
1529+
protobuf code, you must be on Python <= 3.10, and then run `uv add "protobuf<4"` + `uv sync --all-extras`. Then the
1530+
protobuf files can be generated via `poe gen-protos`. Tests can be run for protobuf version 3 by setting the
1531+
`TEMPORAL_TEST_PROTO3` env var to `1` prior to running tests.
15321532

1533-
Do not commit `uv.lock` or `pyproject.toml` changes. To go back from this downgrade, restore both of those files
1534-
and run `uv sync --no-install-project --all-extras`. Make sure you `poe format` the results.
1533+
Do not commit `uv.lock` or `pyproject.toml` changes. To go back from this downgrade, restore both of those files and run
1534+
`uv sync --all-extras`. Make sure you `poe format` the results.
15351535

15361536
For a less system-intrusive approach, you can:
15371537
```shell

scripts/_proto/Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ VOLUME ["/api_new", "/bridge_new"]
77
COPY ./ ./
88

99
RUN mkdir -p ./temporalio/api
10-
RUN uv sync --no-install-project --all-extras
10+
RUN uv sync --all-extras
1111
RUN uv add "protobuf<4"
1212
RUN poe gen-protos
1313

0 commit comments

Comments
 (0)