Skip to content

Commit 434074d

Browse files
committed
Skip failing tests
temporalio/sdk-java#2459
1 parent 434a314 commit 434074d

File tree

1 file changed

+18
-4
lines changed

1 file changed

+18
-4
lines changed

tests/worker/test_activity.py

+18-4
Original file line numberDiff line numberDiff line change
@@ -611,7 +611,12 @@ async def some_activity(param1: SomeClass2, param2: str) -> str:
611611
assert activity_param1 == SomeClass2(foo="str1", bar=SomeClass1(foo=123))
612612

613613

614-
async def test_activity_heartbeat_details(client: Client, worker: ExternalWorker):
614+
async def test_activity_heartbeat_details(
615+
client: Client, worker: ExternalWorker, env: WorkflowEnvironment
616+
):
617+
if env.supports_time_skipping:
618+
pytest.skip("https://github.com/temporalio/sdk-java/issues/2459")
619+
615620
@activity.defn
616621
async def some_activity() -> str:
617622
info = activity.info()
@@ -698,8 +703,11 @@ def picklable_heartbeat_details_activity() -> str:
698703

699704

700705
async def test_sync_activity_thread_heartbeat_details(
701-
client: Client, worker: ExternalWorker
706+
client: Client, worker: ExternalWorker, env: WorkflowEnvironment
702707
):
708+
if env.supports_time_skipping:
709+
pytest.skip("https://github.com/temporalio/sdk-java/issues/2459")
710+
703711
with concurrent.futures.ThreadPoolExecutor(
704712
max_workers=default_max_concurrent_activities
705713
) as executor:
@@ -714,8 +722,11 @@ async def test_sync_activity_thread_heartbeat_details(
714722

715723

716724
async def test_sync_activity_process_heartbeat_details(
717-
client: Client, worker: ExternalWorker
725+
client: Client, worker: ExternalWorker, env: WorkflowEnvironment
718726
):
727+
if env.supports_time_skipping:
728+
pytest.skip("https://github.com/temporalio/sdk-java/issues/2459")
729+
719730
with concurrent.futures.ProcessPoolExecutor() as executor:
720731
result = await _execute_workflow_with_activity(
721732
client,
@@ -1066,8 +1077,11 @@ async def test_activity_async_success(
10661077

10671078
@pytest.mark.parametrize("use_task_token", [True, False])
10681079
async def test_activity_async_heartbeat_and_fail(
1069-
client: Client, worker: ExternalWorker, use_task_token: bool
1080+
client: Client, worker: ExternalWorker, env: WorkflowEnvironment
10701081
):
1082+
if env.supports_time_skipping:
1083+
pytest.skip("https://github.com/temporalio/sdk-java/issues/2459")
1084+
10711085
wrapper = AsyncActivityWrapper()
10721086
# Start task w/ max attempts 2, wait for info, send heartbeat, fail
10731087
task = asyncio.create_task(

0 commit comments

Comments
 (0)