Skip to content

Commit 99a550a

Browse files
committed
fix: skip generic role
1 parent a114f4f commit 99a550a

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/role-helpers.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,8 +154,9 @@ function getRoles(container, {hidden = false} = {}) {
154154

155155
function prettyRoles(dom, {hidden}) {
156156
const roles = getRoles(dom, {hidden})
157-
157+
//We prefer to skip generic role, we don't reccomand it
158158
return Object.entries(roles)
159+
.filter(([role]) => role !== 'generic')
159160
.map(([role, elements]) => {
160161
const delimiterBar = '-'.repeat(50)
161162
const elementsString = elements

src/suggestions.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,10 @@ export function getSuggestedQuery(element, variant = 'get', method) {
8282
return undefined
8383
}
8484

85+
//We prefer to suggest something else if the role is generic
8586
const role =
8687
element.getAttribute('role') ?? getImplicitAriaRoles(element)?.[0]
87-
if (canSuggest('Role', method, role)) {
88+
if (role !== 'generic' && canSuggest('Role', method, role)) {
8889
return makeSuggestion('Role', role, {
8990
variant,
9091
name: computeAccessibleName(element),

0 commit comments

Comments
 (0)