Skip to content

revert: "chore: rename default branch to main (#295)" #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

Hagendorn
Copy link
Member

This reverts commit 965fb04.

@Hagendorn Hagendorn merged commit ef750b2 into master Apr 13, 2022
@Hagendorn Hagendorn deleted the revert/default-branch-renaming branch April 13, 2022 08:52
@github-actions
Copy link

🎉 This PR is included in version 4.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickserv
Copy link
Member

Is there a specific reason this needed to be reverted? If not, I'd prefer to use main, as it's consistent with GitHub's and Testing Library's newer naming conventions.

@Hagendorn
Copy link
Member Author

The automatic release did not work anymore when a commit was merged to main. I did not found the reason and I found no time to rename it to main again. But sure there is no reason to stay with master.

@nickserv
Copy link
Member

nickserv commented Sep 25, 2022

Oh, I think that's because semantic release doesn't enable the main branch by default. I'll try to fix it in #369 soon.

nickserv added a commit that referenced this pull request Sep 25, 2022
Hagendorn pushed a commit that referenced this pull request Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants