Skip to content

Commit cb41aa0

Browse files
authored
Fix coord_sf() regression introduced in draw_axis rewrite (#3361)
* fix regression introduced in draw_axis rewrite * Update sf dopplegangers, stop skipping sf visual test cases (fixes #2684) * use manually generated sf object for tests rather than sf object read from disk
1 parent 859713a commit cb41aa0

8 files changed

+246
-469
lines changed

R/guides-axis.r

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,15 @@ draw_axis <- function(break_positions, break_labels, axis_position, theme) {
7171
)
7272
}
7373

74+
# break_labels can be a list() of language objects
75+
if (is.list(break_labels)) {
76+
if (any(vapply(break_labels, is.language, logical(1)))) {
77+
break_labels <- do.call(expression, break_labels)
78+
} else {
79+
break_labels <- unlist(break_labels)
80+
}
81+
}
82+
7483
labels_grob <- exec(
7584
element_grob, label_element,
7685
!!position_dim := unit(break_positions, "native"),

tests/figs/coord-sf/sf-polygons.svg

Lines changed: 61 additions & 163 deletions
Loading

tests/figs/geom-sf/labels-for-north-carolina.svg

Lines changed: 21 additions & 35 deletions
Loading

0 commit comments

Comments
 (0)