Skip to content

Commit e0ca922

Browse files
committed
Couple of minor improvements
1 parent ae696b9 commit e0ca922

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

packages/node/src/backend.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { BaseBackend } from '@sentry/core';
22
import { Event, EventHint, Severity, Transport, TransportOptions } from '@sentry/types';
33
import { makeDsn, resolvedSyncPromise } from '@sentry/utils';
44

5-
import { eventFromException, eventFromMessage } from './eventbuilder';
5+
import { eventFromError, eventFromMessage } from './eventbuilder';
66
import { HTTPSTransport, HTTPTransport } from './transports';
77
import { NodeOptions } from './types';
88

@@ -16,7 +16,7 @@ export class NodeBackend extends BaseBackend<NodeOptions> {
1616
*/
1717
// eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/explicit-module-boundary-types
1818
public eventFromException(exception: any, hint?: EventHint): PromiseLike<Event> {
19-
return resolvedSyncPromise(eventFromException(exception, hint));
19+
return resolvedSyncPromise(eventFromError(exception, hint));
2020
}
2121

2222
/**

packages/node/src/eventbuilder.ts

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,18 +23,24 @@ export function extractStackFromError(error: Error): StackFrame[] {
2323
* Extracts stack frames from the error and builds a Sentry Exception
2424
*/
2525
export function exceptionFromError(error: Error): Exception {
26-
return {
26+
const exception: Exception = {
2727
type: error.name || error.constructor.name,
2828
value: error.message,
29-
stacktrace: { frames: extractStackFromError(error) },
3029
};
30+
31+
const frames = extractStackFromError(error);
32+
if (frames.length) {
33+
exception.stacktrace = { frames: extractStackFromError(error) };
34+
}
35+
36+
return exception;
3137
}
3238

3339
/**
3440
* Builds and Event from a Exception
3541
* @hidden
3642
*/
37-
export function eventFromException(exception: unknown, hint?: EventHint): Event {
43+
export function eventFromError(exception: unknown, hint?: EventHint): Event {
3844
// eslint-disable-next-line @typescript-eslint/no-explicit-any
3945
let ex: any = exception;
4046
const providedMechanism: Mechanism | undefined =

0 commit comments

Comments
 (0)