Skip to content

Commit fbfd4c1

Browse files
Furong Xusmb49
Furong Xu
authored andcommitted
net: stmmac: xgmac: fix a typo of register name in DPP safety handling
BugLink: https://bugs.launchpad.net/bugs/2059991 commit 1ce2654 upstream. DDPP is copied from Synopsys Data book: DDPP: Disable Data path Parity Protection. When it is 0x0, Data path Parity Protection is enabled. When it is 0x1, Data path Parity Protection is disabled. The macro name should be XGMAC_DPP_DISABLE. Fixes: 46eba19 ("net: stmmac: xgmac: fix handling of DPP safety error for DMA channels") Signed-off-by: Furong Xu <[email protected]> Reviewed-by: Serge Semin <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Paolo Abeni <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]> Signed-off-by: Portia Stephens <[email protected]> Signed-off-by: Roxana Nicolescu <[email protected]>
1 parent 3781332 commit fbfd4c1

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,7 @@
283283
#define XGMAC_TXCEIE BIT(0)
284284
#define XGMAC_MTL_ECC_INT_STATUS 0x000010cc
285285
#define XGMAC_MTL_DPP_CONTROL 0x000010e0
286-
#define XGMAC_DDPP_DISABLE BIT(0)
286+
#define XGMAC_DPP_DISABLE BIT(0)
287287
#define XGMAC_MTL_TXQ_OPMODE(x) (0x00001100 + (0x80 * (x)))
288288
#define XGMAC_TQS GENMASK(25, 16)
289289
#define XGMAC_TQS_SHIFT 16

drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -889,7 +889,7 @@ dwxgmac3_safety_feat_config(void __iomem *ioaddr, unsigned int asp,
889889
/* 5. Enable Data Path Parity Protection */
890890
value = readl(ioaddr + XGMAC_MTL_DPP_CONTROL);
891891
/* already enabled by default, explicit enable it again */
892-
value &= ~XGMAC_DDPP_DISABLE;
892+
value &= ~XGMAC_DPP_DISABLE;
893893
writel(value, ioaddr + XGMAC_MTL_DPP_CONTROL);
894894

895895
return 0;

0 commit comments

Comments
 (0)