Skip to content

Commit 302c0fc

Browse files
committed
check completion kind before calling isclasslikemembercompletion
1 parent 3a6b6bf commit 302c0fc

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

src/compiler/checker.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -729,7 +729,7 @@ namespace ts {
729729
isDeclarationVisible,
730730
isPropertyAccessible,
731731
getTypeOnlyAliasDeclaration,
732-
getMemberOverrideModifierStatus: getMemberOverrideModifierStatus,
732+
getMemberOverrideModifierStatus,
733733
};
734734

735735
function getResolvedSignatureWorker(nodeIn: CallLikeExpression, candidatesOutArray: Signature[] | undefined, argumentCount: number | undefined, checkMode: CheckMode): Signature | undefined {

src/services/completions.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -635,6 +635,7 @@ namespace ts.Completions {
635635
useSemicolons: boolean,
636636
options: CompilerOptions,
637637
preferences: UserPreferences,
638+
completionKind: CompletionKind,
638639
): CompletionEntry | undefined {
639640
let insertText: string | undefined;
640641
let replacementSpan = getReplacementSpanForContextToken(replacementToken);
@@ -697,7 +698,7 @@ namespace ts.Completions {
697698
}
698699
}
699700

700-
if (preferences.includeCompletionsWithInsertText && isClassLikeMemberCompletion(symbol, location)) {
701+
if (preferences.includeCompletionsWithInsertText && completionKind === CompletionKind.MemberLike && isClassLikeMemberCompletion(symbol, location)) {
701702
({ insertText, isSnippet } = getEntryForMemberCompletion(host, program, options, preferences, name, symbol, location, contextToken));
702703
}
703704

@@ -1164,7 +1165,8 @@ namespace ts.Completions {
11641165
importCompletionNode,
11651166
useSemicolons,
11661167
compilerOptions,
1167-
preferences
1168+
preferences,
1169+
kind,
11681170
);
11691171
if (!entry) {
11701172
continue;

0 commit comments

Comments
 (0)