Skip to content

Commit 52bf679

Browse files
committed
to revert: debug statements for CI
Signed-off-by: alec-flowers <[email protected]>
1 parent 7ec5feb commit 52bf679

File tree

5 files changed

+10
-0
lines changed

5 files changed

+10
-0
lines changed

tests/v1/engine/test_engine_core_client.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -331,12 +331,16 @@ def test_kv_cache_events(
331331
"Token ids should be the same as the custom tokens")
332332
assert event.token_ids == custom_tokens, (
333333
"Token ids should be the same as the custom tokens")
334+
print("Asserts Finished")
334335
finally:
335336
client.shutdown()
337+
print("Client Shutdown")
336338
subscriber.close()
339+
print("Subscriber Shutdown")
337340
# TODO hack to try and fix CI hang
338341
ctx = zmq.Context.instance()
339342
ctx.term()
343+
print("Context Shutdown")
340344
return
341345

342346

vllm/distributed/kv_events.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,7 @@ def shutdown(self) -> None:
171171
self._thread.join(timeout=self.SHUTDOWN_TIMEOUT)
172172

173173
# Clean up ZMQ resources
174+
logger.info("ZmqEventPublisher - Shutting down ZMQ sockets")
174175
try:
175176
if self._pub is not None:
176177
self._pub.close(linger=0)

vllm/v1/core/sched/scheduler.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -854,4 +854,5 @@ def make_spec_decoding_stats(
854854

855855
def shutdown(self) -> None:
856856
if self.kv_event_publisher:
857+
logger.info("scheduler.py - Shutting down kv event publisher")
857858
self.kv_event_publisher.shutdown()

vllm/v1/engine/core.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -258,6 +258,7 @@ def shutdown(self):
258258
if self.model_executor:
259259
self.model_executor.shutdown()
260260
if self.scheduler:
261+
logger.info("core.py - Shutting down scheduler")
261262
self.scheduler.shutdown()
262263

263264
def profile(self, is_start: bool = True):

vllm/v1/engine/core_client.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -323,6 +323,8 @@ def __call__(self):
323323

324324
# ZMQ context termination can hang if the sockets
325325
# aren't explicitly closed first.
326+
327+
logger.info("BackgroundResources - Closing output socket")
326328
if self.output_socket is not None:
327329
self.output_socket.close(linger=0)
328330
if self.input_socket is not None:
@@ -334,6 +336,7 @@ def __call__(self):
334336
shutdown_sender.connect(self.shutdown_path)
335337
# Send shutdown signal.
336338
shutdown_sender.send(b'')
339+
logger.info("BackgroundResources - Shutdown signal sent")
337340

338341
def validate_alive(self, frames: Sequence[zmq.Frame]):
339342
if len(frames) == 1 and (frames[0].buffer

0 commit comments

Comments
 (0)