Skip to content

fix(runtime-dom): teleport mount after suspense is resolved #8619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

fix(runtime-dom): teleport mount after suspense is resolved #8619

wants to merge 11 commits into from

Conversation

baiwusanyu-c
Copy link
Member

close: #8603

@baiwusanyu-c

This comment was marked as outdated.

Sign in to view
edison1105
edison1105 reviewed Jun 21, 2023
View reviewed changes
@baiwusanyu-c baiwusanyu-c changed the title feat(runtime-dom): teleport mount after suspense is resolved fix(runtime-dom): teleport mount after suspense is resolved Jun 21, 2023
@baiwusanyu-c baiwusanyu-c requested a review from edison1105 June 21, 2023 07:38
edison1105
edison1105 requested changes Jun 21, 2023
View reviewed changes
@baiwusanyu-c baiwusanyu-c requested a review from edison1105 June 21, 2023 08:56
@baiwusanyu-c
Merge remote-tracking branch 'origin/main' into bwsy/feat/suspense-in…
8b59cd4 
…ner-hooks

# Conflicts:
#	packages/runtime-core/__tests__/components/Suspense.spec.ts
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2023 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (+20 B) 37.7 kB (+6 B) 33.9 kB (-42 B)
vue.global.prod.js 159 kB (+20 B) 57.6 kB (+6 B) 51.2 kB (-33 B)

Usages

Name Size Gzip Brotli
createApp 55.2 kB 21.2 kB 19.4 kB
createSSRApp 59.1 kB 22.9 kB 20.9 kB
defineCustomElement 59.9 kB 22.8 kB 20.7 kB
overall 68.9 kB 26.3 kB 23.9 kB

baiwusanyu-c and others added 2 commits January 3, 2024 10:23
@baiwusanyu-c
Merge remote-tracking branch 'origin/main' into bwsy/feat/suspense-in…
f70a914 
…ner-hooks

# Conflicts:
#	packages/runtime-core/__tests__/components/Suspense.spec.ts
#	packages/runtime-core/src/components/Teleport.ts
@autofix-ci
[autofix.ci] apply automated fixes
f98a2fd
@edison1105 edison1105 added scope: suspense 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready for review This PR requires more reviews labels Aug 1, 2024
baiwusanyu-c and others added 2 commits September 5, 2024 13:52
Merge remote-tracking branch 'upstream/main' into bwsy/feat/suspense-…
3297d92 
…inner-hooks

# Conflicts:
#	packages/runtime-core/__tests__/components/Suspense.spec.ts
#	packages/runtime-core/src/components/Teleport.ts
@autofix-ci
[autofix.ci] apply automated fixes
dc6c416
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 5, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@8619

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@8619

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@8619

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@8619

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@8619

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@8619

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@8619

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@8619

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@8619

vue

pnpm add https://pkg.pr.new/vue@8619

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@8619

commit: dc6c416

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edison1105 edison1105 edison1105 approved these changes

Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready for review This PR requires more reviews scope: suspense
Projects
Issue / PR Management
Status: Needs Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Teleport rendered before async dependencies resolve in Suspense component
2 participants
@baiwusanyu-c @edison1105