Skip to content

Commit 1975c6a

Browse files
iluuu1994charmitro
authored andcommitted
[skip ci] Use !cancelled() over always() in GHA config
According to the documentation, !cancelled() should be used over always() when the step should be executed regardless of success of failure, but canceled when the workflow is canceled. See https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/evaluate-expressions-in-workflows-and-actions#always
1 parent 43585b3 commit 1975c6a

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

.github/workflows/nightly.yml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -427,7 +427,7 @@ jobs:
427427
-d zend_extension=opcache.so
428428
-d opcache.enable_cli=1
429429
- uses: codecov/codecov-action@v4
430-
if: always()
430+
if: !cancelled()
431431
with:
432432
fail_ci_if_error: true
433433
token: ${{ secrets.CODECOV_TOKEN }}
@@ -500,7 +500,7 @@ jobs:
500500
echo opcache.jit_hot_side_exit=1 >> /etc/php.d/opcache.ini
501501
php -v
502502
- name: Test AMPHP
503-
if: always()
503+
if: !cancelled()
504504
run: |
505505
repositories="amp cache dns file http parallel parser pipeline process serialization socket sync websocket-client websocket-server"
506506
X=0
@@ -518,7 +518,7 @@ jobs:
518518
done
519519
exit $X
520520
- name: Test Laravel
521-
if: always()
521+
if: !cancelled()
522522
run: |
523523
git clone https://github.com/laravel/framework.git --branch=master --depth=1
524524
cd framework
@@ -531,7 +531,7 @@ jobs:
531531
exit 1
532532
fi
533533
- name: Test ReactPHP
534-
if: always()
534+
if: !cancelled()
535535
run: |
536536
repositories="async cache child-process datagram dns event-loop promise promise-stream promise-timer stream"
537537
X=0
@@ -549,7 +549,7 @@ jobs:
549549
done
550550
exit $X
551551
- name: Test Revolt PHP
552-
if: always()
552+
if: !cancelled()
553553
run: |
554554
git clone https://github.com/revoltphp/event-loop.git --depth=1
555555
cd event-loop
@@ -560,7 +560,7 @@ jobs:
560560
exit 1
561561
fi
562562
- name: Test Symfony
563-
if: always() && !inputs.skip_symfony
563+
if: !cancelled() && !inputs.skip_symfony
564564
run: |
565565
git clone https://github.com/symfony/symfony.git --depth=1
566566
cd symfony
@@ -581,7 +581,7 @@ jobs:
581581
done
582582
exit $X
583583
- name: Test PHPUnit
584-
if: always()
584+
if: !cancelled()
585585
run: |
586586
git clone https://github.com/sebastianbergmann/phpunit.git --branch=main --depth=1
587587
cd phpunit
@@ -592,15 +592,15 @@ jobs:
592592
exit 1
593593
fi
594594
- name: 'Symfony Preloading'
595-
if: always() && !inputs.skip_symfony
595+
if: !cancelled() && !inputs.skip_symfony
596596
run: |
597597
php /usr/bin/composer create-project symfony/symfony-demo symfony_demo --no-progress --ignore-platform-reqs
598598
cd symfony_demo
599599
git rev-parse HEAD
600600
sed -i 's/PHP_SAPI/"cli-server"/g' var/cache/dev/App_KernelDevDebugContainer.preload.php
601601
php -d opcache.preload=var/cache/dev/App_KernelDevDebugContainer.preload.php public/index.php
602602
- name: Test Wordpress
603-
if: always() && !inputs.skip_wordpress
603+
if: !cancelled() && !inputs.skip_wordpress
604604
run: |
605605
git clone https://github.com/WordPress/wordpress-develop.git wordpress --depth=1
606606
cd wordpress

0 commit comments

Comments
 (0)