Skip to content

Commit f66d01f

Browse files
fix: using new dev server API for v4 (#2886)
1 parent a4c83e9 commit f66d01f

File tree

1 file changed

+19
-9
lines changed

1 file changed

+19
-9
lines changed

packages/serve/src/index.ts

Lines changed: 19 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,11 @@ class ServeCommand {
145145
process.stdin.on("end", () => {
146146
Promise.all(
147147
servers.map((server) => {
148+
if (typeof server.stop === "function") {
149+
return server.stop();
150+
}
151+
152+
// TODO remove in the next major release
148153
return new Promise<void>((resolve) => {
149154
server.close(() => {
150155
resolve();
@@ -333,15 +338,20 @@ class ServeCommand {
333338
server = new DevServer(compiler, devServerOptions);
334339
}
335340

336-
server.listen(
337-
devServerOptions.port,
338-
devServerOptions.host,
339-
(error): void => {
340-
if (error) {
341-
throw error;
342-
}
343-
},
344-
);
341+
if (typeof server.start === "function") {
342+
await server.start();
343+
} else {
344+
// TODO remove in the next major release
345+
server.listen(
346+
devServerOptions.port,
347+
devServerOptions.host,
348+
(error): void => {
349+
if (error) {
350+
throw error;
351+
}
352+
},
353+
);
354+
}
345355

346356
servers.push(server);
347357
} catch (error) {

0 commit comments

Comments
 (0)