Skip to content

docs(config) Small improvements to configuration watch page #2751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2019
Merged

docs(config) Small improvements to configuration watch page #2751

merged 1 commit into from
Jan 22, 2019

Conversation

EugeneHlushko
Copy link
Member

  • general tidy up for examples
  • types defaults are now consistent
  • provided extra links for dev-server and dev-midlwr

hemal7735
hemal7735 reviewed Jan 10, 2019
View reviewed changes
hemal7735
hemal7735 approved these changes Jan 10, 2019
View reviewed changes
Copy link
Member

@hemal7735 hemal7735 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comment.
LGTM 👍

@hemal7735
Copy link
Member

@EugeneHlushko was wondering if you can also add more details about what each option of info-verbosity means.

@montogeek montogeek merged commit dfe9c47 into master Jan 22, 2019
@montogeek
Copy link
Member

Thanks!

@montogeek montogeek deleted the config/watch branch January 22, 2019 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hemal7735 hemal7735 hemal7735 approved these changes

@montogeek montogeek montogeek approved these changes

@dhruvdutt dhruvdutt dhruvdutt approved these changes

Assignees
No one assigned
Labels
Configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EugeneHlushko @hemal7735 @montogeek @dhruvdutt