Skip to content

Commit 872bbbd

Browse files
committed
Merge pull request #654 from JacksonTian/concat
Use Buffer.concat() instead of private concatBuffers method
2 parents ffed6ef + ed4a278 commit 872bbbd

File tree

3 files changed

+5
-20
lines changed

3 files changed

+5
-20
lines changed

lib/BufferUtil.fallback.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* MIT Licensed
55
*/
66

7-
module.exports.BufferUtil = {
7+
exports.BufferUtil = {
88
merge: function(mergedBuffer, buffers) {
99
var offset = 0;
1010
for (var i = 0, l = buffers.length; i < l; ++i) {

lib/Receiver.js

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -307,20 +307,6 @@ Receiver.prototype.unmask = function (mask, buf, binary) {
307307
return buf != null ? buf.toString('utf8') : '';
308308
};
309309

310-
/**
311-
* Concatenates a list of buffers.
312-
*
313-
* @api private
314-
*/
315-
316-
Receiver.prototype.concatBuffers = function(buffers) {
317-
var length = 0;
318-
for (var i = 0, l = buffers.length; i < l; ++i) length += buffers[i].length;
319-
var mergedBuffer = new Buffer(length);
320-
bufferUtil.merge(mergedBuffer, buffers);
321-
return mergedBuffer;
322-
};
323-
324310
/**
325311
* Handles an error
326312
*
@@ -539,7 +525,7 @@ var opcodes = {
539525
self.currentMessageLength += buffer.length;
540526
}
541527
if (state.lastFragment) {
542-
var messageBuffer = self.concatBuffers(self.currentMessage);
528+
var messageBuffer = Buffer.concat(self.currentMessage);
543529
self.currentMessage = [];
544530
self.currentMessageLength = 0;
545531
if (!Validation.isValidUTF8(messageBuffer)) {
@@ -635,7 +621,7 @@ var opcodes = {
635621
self.currentMessageLength += buffer.length;
636622
}
637623
if (state.lastFragment) {
638-
var messageBuffer = self.concatBuffers(self.currentMessage);
624+
var messageBuffer = Buffer.concat(self.currentMessage);
639625
self.currentMessage = [];
640626
self.currentMessageLength = 0;
641627
self.onbinary(messageBuffer, {masked: state.masked, buffer: messageBuffer});

lib/Validation.fallback.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,9 @@
33
* Copyright(c) 2011 Einar Otto Stangvik <[email protected]>
44
* MIT Licensed
55
*/
6-
7-
module.exports.Validation = {
6+
7+
exports.Validation = {
88
isValidUTF8: function(buffer) {
99
return true;
1010
}
1111
};
12-

0 commit comments

Comments
 (0)