Skip to content

Commit 88960bb

Browse files
committed
more fixes to string.c
1 parent 62c1f41 commit 88960bb

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

ext/standard/string.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2290,7 +2290,7 @@ PHP_FUNCTION(substr_replace)
22902290
zval **repl;
22912291
char *result;
22922292
zend_str_size result_len;
2293-
int l = 0;
2293+
int l = 0; /* l and f should be size_t, however this needs much closer below logic investigation.*/
22942294
int f;
22952295
int argc = ZEND_NUM_ARGS();
22962296

@@ -3226,7 +3226,7 @@ PHP_FUNCTION(similar_text)
32263226
char *t1, *t2;
32273227
zval **percent = NULL;
32283228
int ac = ZEND_NUM_ARGS();
3229-
int sim;
3229+
zend_str_size_int sim;
32303230
zend_str_size t1_len, t2_len;
32313231

32323232
if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "SS|Z", &t1, &t1_len, &t2, &t2_len, &percent) == FAILURE) {
@@ -4145,7 +4145,7 @@ static void php_hebrev(INTERNAL_FUNCTION_PARAMETERS, int convert_newlines)
41454145
}
41464146
}
41474147
if (char_count == max_chars) { /* try to avoid breaking words */
4148-
int new_char_count=char_count, new_begin=begin;
4148+
zend_str_size_int new_char_count=char_count, new_begin=begin;
41494149

41504150
while (new_char_count > 0) {
41514151
if (_isblank(heb_str[new_begin]) || _isnewline(heb_str[new_begin])) {

0 commit comments

Comments
 (0)