Rollup merge of rust-lang#97079 - SparrowLii:successors, r=lcnr

JohnTitor · web-flow · commit ae9d727b8db5 · 2022-05-17T19:01:32.000+09:00
Change `Successors` to `impl Iterator&lt;Item = BasicBlock&gt;`

This PR fixes the FIXME in `compiler\rustc_middle\src\mir\mod.rs`.
This can omit several `&amp;`, `*` or `cloned` operations on Successros' generated elements
diff --git a/clippy_lints/src/redundant_clone.rs b/clippy_lints/src/redundant_clone.rs
@@ -114,7 +114,7 @@ impl<'tcx> LateLintPass<'tcx> for RedundantClone {
             }
 
             // Give up on loops
-            if terminator.successors().any(|s| *s == bb) {
+            if terminator.successors().any(|s| s == bb) {
                 continue;
             }
 
@@ -440,7 +440,7 @@ fn visit_clone_usage(cloned: mir::Local, clone: mir::Local, mir: &mir::Body<'_>,
             // Short-circuit
             if (usage.cloned_used && usage.clone_consumed_or_mutated) ||
                 // Give up on loops
-                tdata.terminator().successors().any(|s| *s == bb)
+                tdata.terminator().successors().any(|s| s == bb)
             {
                 return CloneUsage {
                     cloned_used: true,

Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,7 @@ impl<'tcx> LateLintPass<'tcx> for RedundantClone {`
`114`	`114`	`}`
`115`	`115`
`116`	`116`	`// Give up on loops`
`117`		`- if terminator.successors().any(\|s\| *s == bb) {`
	`117`	`+ if terminator.successors().any(\|s\| s == bb) {`
`118`	`118`	`continue;`
`119`	`119`	`}`
`120`	`120`
`@@ -440,7 +440,7 @@ fn visit_clone_usage(cloned: mir::Local, clone: mir::Local, mir: &mir::Body<'_>,`
`440`	`440`	`// Short-circuit`
`441`	`441`	`if (usage.cloned_used && usage.clone_consumed_or_mutated) \|\|`
`442`	`442`	`// Give up on loops`
`443`		`- tdata.terminator().successors().any(\|s\| *s == bb)`
	`443`	`+ tdata.terminator().successors().any(\|s\| s == bb)`
`444`	`444`	`{`
`445`	`445`	`return CloneUsage {`
`446`	`446`	`cloned_used: true,`