fix(object-literal-completions): TypeScript completion got frozen #123

Author: zardoy

.github/workflows/ci.yml

@@ -28,7 +28,7 @@ jobs:
       - run: pnpm lint
       - run: pnpm vscode-utils prepareFrameworkBuild
       - run: pnpm build
-      - run: pnpm test-plugin
+      - run: timeout 60 pnpm test-plugin
       - uses: GabrielBB/[email protected]
         with:
           run: pnpm integration-test

typescript/src/completions/objectLiteralCompletions.ts

@@ -21,15 +21,15 @@ export default (
         const nextChar = node.getSourceFile().getFullText()[position]
         if (!ts.isObjectLiteralExpression(node) || nextChar === ':') return
 
-        entries = [...entries]
         const typeChecker = languageService.getProgram()!.getTypeChecker()!
         const objType = typeChecker.getContextualType(node)
         let oldProperties: ts.Symbol[] | undefined
         if (!isTs5()) {
             if (!objType) return
             oldProperties = getAllPropertiesOfType(objType, typeChecker)
         }
-        for (const entry of entries) {
+        // eslint-disable-next-line unicorn/no-useless-spread
+        for (const entry of [...entries]) {
             let type: ts.Type | undefined
             if (!isTs5()) {
                 const property = oldProperties!.find(property => property.name === entry.name)

typescript/test/completions.spec.ts

@@ -534,7 +534,7 @@ test('Additional types suggestions', () => {
     })
 })
 
-test.skip('Object Literal Completions', () => {
+test('Object Literal Completions', () => {
     const [_positivePositions, _negativePositions, numPositions] = fileContentsSpecialPositions(/* ts */ `
     interface Options {
         usedOption