feat: Add workaround way for inserting name of completion. Enable it via experimental.enableInsertNameOfSuggestionFix

Author: zardoy

src/configurationType.ts

@@ -605,6 +605,12 @@ export type Configuration = {
               typeAlias: string
               interface: string
           }
+    /**
+     * Use workaround method for inserting name of TypeScript suggestion.
+     * If you move to next suggestion and then to previous, and then run *insert name of completion* via keybinding, name of **last resolved** completion will be inserted, so you might prefer to enable this setting. Also it makes this feature work in Vue.
+     * @default false
+     */
+    'experimental.enableInsertNameOfSuggestionFix': boolean
 }
 
 // scrapped using search editor. config: caseInsesetive, context lines: 0, regex: const fix\w+ = "[^ ]+"

src/onCompletionAccepted.ts

@@ -3,19 +3,19 @@ import { getActiveRegularEditor } from '@zardoy/vscode-utils'
 import { expandPosition } from '@zardoy/vscode-utils/build/position'
 import { getExtensionSetting, registerExtensionCommand } from 'vscode-framework'
 import { oneOf } from '@zardoy/utils'
-import { RequestOptionsTypes, RequestResponseTypes } from '../typescript/src/ipcTypes'
-import { sendCommand } from './sendCommand'
+
+export const onCompletionAcceptedOverride: { value: ((item: any) => void) | undefined } = { value: undefined }
 
 export default (tsApi: { onCompletionAccepted }) => {
     let inFlightMethodSnippetOperation: undefined | AbortController
     let justAcceptedReturnKeywordSuggestion = false
     let lastAcceptedAmbiguousMethodSnippetSuggestion: string | undefined
-    let onCompletionAcceptedOverride: ((item: any) => void) | undefined
 
     // eslint-disable-next-line complexity
     tsApi.onCompletionAccepted(async (item: vscode.CompletionItem & { document: vscode.TextDocument; tsEntry }) => {
-        if (onCompletionAcceptedOverride) {
-            onCompletionAcceptedOverride(item)
+        if (onCompletionAcceptedOverride.value) {
+            onCompletionAcceptedOverride.value(item)
+            onCompletionAcceptedOverride.value = undefined
             return
         }
 
@@ -100,10 +100,9 @@ export default (tsApi: { onCompletionAccepted }) => {
             async (_progress, token) => {
                 const accepted = await new Promise<boolean>(resolve => {
                     token.onCancellationRequested(() => {
-                        onCompletionAcceptedOverride = undefined
                         resolve(false)
                     })
-                    onCompletionAcceptedOverride = item => {
+                    onCompletionAcceptedOverride.value = item => {
                         console.dir(item, { depth: 4 })
                         resolve(true)
                     }

src/specialCommands.ts

@@ -1,12 +1,14 @@
 import * as vscode from 'vscode'
 import { getActiveRegularEditor } from '@zardoy/vscode-utils'
-import { getExtensionCommandId, registerExtensionCommand, VSCodeQuickPickItem } from 'vscode-framework'
+import { getExtensionCommandId, getExtensionSetting, registerExtensionCommand, VSCodeQuickPickItem } from 'vscode-framework'
 import { showQuickPick } from '@zardoy/vscode-utils/build/quickPick'
 import _ from 'lodash'
 import { compact } from '@zardoy/utils'
+import { offsetPosition } from '@zardoy/vscode-utils/build/position'
 import { RequestOptionsTypes, RequestResponseTypes } from '../typescript/src/ipcTypes'
 import { sendCommand } from './sendCommand'
 import { tsRangeToVscode, tsRangeToVscodeSelection } from './util'
+import { onCompletionAcceptedOverride } from './onCompletionAccepted'
 
 export default () => {
     registerExtensionCommand('removeFunctionArgumentsTypesInSelection', async () => {
@@ -241,8 +243,37 @@ export default () => {
     registerExtensionCommand('insertNameOfCompletion', async () => {
         const editor = vscode.window.activeTextEditor
         if (!editor) return
-        const result = await sendCommand<RequestResponseTypes['getLastResolvedCompletion']>('getLastResolvedCompletion')
-        if (!result) return
-        await editor.insertSnippet(new vscode.SnippetString().appendText(result.name))
+        if (!getExtensionSetting('experimental.enableInsertNameOfSuggestionFix')) {
+            const result = await sendCommand<RequestResponseTypes['getLastResolvedCompletion']>('getLastResolvedCompletion')
+            if (!result) return
+            await editor.insertSnippet(new vscode.SnippetString().appendText(result.name))
+            return
+        }
+
+        onCompletionAcceptedOverride.value = () => {}
+        const { ranges, text } = await new Promise<{ text: string; ranges: vscode.Range[] }>(resolve => {
+            vscode.workspace.onDidChangeTextDocument(({ document, contentChanges }) => {
+                if (document !== editor.document || contentChanges.length === 0) return
+                const ranges = contentChanges.map(
+                    change => new vscode.Range(change.range.start, offsetPosition(document, change.range.start, change.text.length)),
+                )
+                resolve({ ranges, text: contentChanges[0]!.text })
+            })
+            void vscode.commands.executeCommand('acceptSelectedSuggestion')
+        })
+        const needle = ['(', ': '].find(needle => text.includes(needle))
+        if (!needle) return
+        const cleanedText = text.slice(0, text.indexOf(needle))
+        await editor.edit(
+            e => {
+                for (const range of ranges) {
+                    e.replace(range, cleanedText)
+                }
+            },
+            {
+                undoStopBefore: false,
+                undoStopAfter: false,
+            },
+        )
     })
 }