Fix go-gitea#16235

zeripath · zeripath · commit e1a015fca5e3 · 2021-06-23T22:32:11.000+01:00
Signed-off-by: Andrew Thornton &lt;art27@cantab.net&gt;
diff --git a/services/auth/signin.go b/services/auth/signin.go
@@ -102,7 +102,11 @@ func UserSignIn(username, password string) (*models.User, error) {
 			err = models.ErrUserProhibitLogin{UID: authUser.ID, Name: authUser.Name}
 		}
 
-		log.Warn("Failed to login '%s' via '%s': %v", username, source.Name, err)
+		if models.IsErrUserNotExist(err) {
+			log.Debug("Failed to login '%s' via '%s': %v", username, source.Name, err)
+		} else {
+			log.Warn("Failed to login '%s' via '%s': %v", username, source.Name, err)
+		}
 	}
 
 	return nil, models.ErrUserNotExist{Name: username}

Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,11 @@ func UserSignIn(username, password string) (*models.User, error) {`
`102`	`102`	`err = models.ErrUserProhibitLogin{UID: authUser.ID, Name: authUser.Name}`
`103`	`103`	`}`
`104`	`104`
`105`		`- log.Warn("Failed to login '%s' via '%s': %v", username, source.Name, err)`
	`105`	`+ if models.IsErrUserNotExist(err) {`
	`106`	`+ log.Debug("Failed to login '%s' via '%s': %v", username, source.Name, err)`
	`107`	`+ } else {`
	`108`	`+ log.Warn("Failed to login '%s' via '%s': %v", username, source.Name, err)`
	`109`	`+ }`
`106`	`110`	`}`
`107`	`111`
`108`	`112`	`return nil, models.ErrUserNotExist{Name: username}`