Work-Around: pybind11 type aliases on Win #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`amrex::DefaultAllocator` is not properly resolved as the same type on Windows in pybind11.
ax3l
force-pushed
the
fix-allocator-aliases-windows
branch
2 times, most recently
from
9a5bd21 to
3784304
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+131
to
+133
| // work-around for https://github.com/pybind/pybind11/pull/4581 | ||
| //make_ArrayOfStructs<NReal, NInt, std::allocator> (m, "std"); | ||
| //make_ArrayOfStructs<NReal, NInt, amrex::ArenaAllocator> (m, "arena"); |
Check notice
Code scanning / CodeQL
Commented-out code
Comment on lines
+53
to
+55
| // work-around for https://github.com/pybind/pybind11/pull/4581 | ||
| //make_StructOfArrays<NReal, NInt, std::allocator>(m, "std"); | ||
| //make_StructOfArrays<NReal, NInt, amrex::ArenaAllocator>(m, "arena"); |
Check notice
Code scanning / CodeQL
Commented-out code
ax3l
force-pushed
the
fix-allocator-aliases-windows
branch
from
3784304 to
12d8b3d
Compare
... and skip what it stands for.
ax3l
force-pushed
the
fix-allocator-aliases-windows
branch
from
12d8b3d to
023ea80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
amrex::DefaultAllocatoris not properly resolved as the same type on Windows in pybind11.X-ref:
std::hash<std::type_index>,std::equal_to<std::type_index>everywhere **except when libc++ is in use** pybind/pybind11#4319