Adjust clang's multilib flags test to cope with missing variant #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The clang driver's `print-multi-selection-flags.c` test uses a combination of command line options in one of its RUN lines for which we don't have a valid library variant available. Since the merging of PR ARM-software#500, this combination of options now trigger an error to inform the user of an unsupported setup, but this error also causes the test to fail. This adds a new patch file for llvm-project to adjust the test accordingly.
|
Would it instead be possible to fix the test upstream to avoid using our multilib.yaml at all? There are other tests, e.g. |
|
The change to upstream is under review, but it's taking a while to progress. Should we go ahead with this change for now and revert it once the upstream PR gets merged? |
ostannard
approved these changes
Oct 3, 2024
pratlucas
added a commit
that referenced
this pull request
Oct 7, 2024
…nt" (#527) Reverts #504. The upstream change from llvm/llvm-project#109640 has now been merged, allowing tests to specify multilib yaml file using a new command line option. The relevant tests have been updated by that change, so the downstream adjustment is no longer needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The clang driver's
print-multi-selection-flags.ctest uses acombination of command line options in one of its RUN lines for which we
don't have a valid library variant available.
Since the merging of PR #500, this combination of options now trigger an
error to inform the user of an unsupported setup, but this error also
causes the test to fail.
This adds a new patch file for llvm-project to adjust the test
accordingly.