Skip to content

Make WebSocketUpgradeHandler extensible in a controlled manner. #1446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2017
Merged

Make WebSocketUpgradeHandler extensible in a controlled manner. #1446

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions client/src/main/java/org/asynchttpclient/ws/WebSocketUpgradeHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,29 +36,41 @@ public class WebSocketUpgradeHandler implements AsyncHandler<NettyWebSocket> {
public WebSocketUpgradeHandler(List<WebSocketListener> listeners) {
this.listeners = listeners;
}

protected void onStatusReceived0(HttpResponseStatus responseStatus) throws Exception {}
protected void onHeadersReceived0(HttpHeaders headers) throws Exception {}
protected void onBodyPartReceived0(HttpResponseBodyPart bodyPart) throws Exception {}
protected void onCompleted0() throws Exception {}
protected void onThrowable0(Throwable t) {}
protected void onOpen0() {}

@Override
public final State onStatusReceived(HttpResponseStatus responseStatus) throws Exception {
onStatusReceived0(responseStatus);
return responseStatus.getStatusCode() == SWITCHING_PROTOCOLS ? State.CONTINUE : State.ABORT;
}

@Override
public final State onHeadersReceived(HttpHeaders headers) throws Exception {
onHeadersReceived0(headers);
return State.CONTINUE;
}

@Override
public final State onBodyPartReceived(HttpResponseBodyPart bodyPart) throws Exception {
onBodyPartReceived0(bodyPart);
return State.CONTINUE;
}

@Override
public final NettyWebSocket onCompleted() throws Exception {
onCompleted0();
return webSocket;
}

@Override
public final void onThrowable(Throwable t) {
onThrowable0(t);
for (WebSocketListener listener : listeners) {
if (webSocket != null) {
webSocket.addWebSocketListener(listener);
Expand All @@ -72,6 +84,7 @@ public final void setWebSocket(NettyWebSocket webSocket) {
}

public final void onOpen() {
onOpen0();
for (WebSocketListener listener : listeners) {
webSocket.addWebSocketListener(listener);
listener.onOpen(webSocket);
Expand Down