Introduce Grizzly 2.0-based provider for Async HTTP Client #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…this is a decent start.
cs-workco
pushed a commit
to cs-workco/async-http-client
that referenced
this pull request
Apr 13, 2023
Motivation: Allowing readers of the API documentation to drill into the implementation of documented declarations can be educational and helpful for debugging, among several other reasons. Modifications: Add --github-file-prefix appending the current version in order to keep stable links. This means that documentation generated from any non-release revision may resolve incorrectly. This can be refined in the doc generation script later if it is deemed problematic by resolving to the commit sha if it doesn't exactly align with the version. Result: Users will be able to click a 'Show on GitHub' for all documented API declarations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests introduces a Grizzly 2.0-based provider for the Async HTTP Client library.
The 2.0 provider passes all defined tests, however, it still needs some work and additional testing via actual users, so I'd say this provider is alpha quality at the moment.
Another item to be aware of is that Grizzly 2.0 requires JDK 1.6. I've updated the build such that the Grizzly provider will not be compiled if AHC is built using 1.5. Additionally, I've added a bundles module to create a Grizzly-only distribution. Other distributions can, of course, be added. I'll be the first to admit that I'm far from being a maven expert, so upon review of the structural/build changes if there are suggestions on how to better deal JDK 1.5 vs 1.6 and provider specific bundles, please let me know and I'll make the appropriate changes.