Skip to content

Add Requires check for AAD module and run as admin #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2020

Conversation

BrianTJackett
Copy link
Contributor

Purpose

  • Proposed change checks for the AzureAD module installed prior to start and throws an error if not present.
  • Proposed change checks for elevated process (run as admin) prior to start and throws an error if condition not met.

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[X] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • Run the script on a machine that does not have the AzureAD module installed
  • Run the script without an elevated process (not as administrator)

Other Information

Can remove additional lines of script for installing AzureAD module near bottom if desired after merging changes.

@jmprieur
Copy link
Contributor

@kalyankrishna1 @TiagoBrenck do we want to update the generator with this?

@jmprieur
Copy link
Contributor

Thanks @BrianTJackett

@kalyankrishna1
Copy link
Contributor

@jmprieur , @BrianTJackett noted. the next update will have this.

@jmprieur jmprieur merged commit 01fd633 into Azure-Samples:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants