fix: #8264 - fully qualified string not used for types in dataloader generator

[svihpinc]

Summary of the changes (Less than 80 chars)

• To always get the correct types in generator dataloaders, use the fully qualified string for all types

Closes #8264 (in this specific format)

[CLAassistant]

All committers have signed the CLA.

[michaelstaib]

Can you add a nullable test case? for both structs and classes?

They should go here:
https://github.com/ChilliCream/graphql-platform/blob/main/src/HotChocolate/Core/test/Types.Analyzers.Tests/DataLoaderTests.cs

[Copilot]

Pull Request Overview

This PR ensures that fully qualified type names are used consistently in DataLoader generators to address issue #8264. Key changes include:

• Updating snapshot files to use fully qualified type strings for resultMap parameters.
• Adding a new extension method, ToFullyQualifiedWithNullRefQualifier, in SymbolExtensions.cs.
• Refactoring DataLoaderFileBuilder to utilize the new helper instead of a hardcoded "global::" prefix.

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

File	Description
snapshots/DataLoaderTests.*.md	Updated snapshots to include fully qualified type names.
SymbolExtensions.cs	Added an extension method for fully qualified type formatting with null ref qualifier.
DataLoaderFileBuilder.cs	Updated to use the new extension method for the resultMap parameter.

Comments suppressed due to low confidence (1)

src/HotChocolate/Core/src/Types.Analyzers/Helpers/SymbolExtensions.cs:35

• Consider adding unit tests for the new ToFullyQualifiedWithNullRefQualifier method to verify its behavior across various type scenarios.

public static string ToFullyQualifiedWithNullRefQualifier(this ITypeSymbol typeSymbol)

[svihpinc]

@michaelstaib nullable test cases are already present, eg:

graphql-platform/src/HotChocolate/Core/test/Types.Analyzers.Tests/DataLoaderTests.cs

Line 313 in 819f23c

public static Task<Dictionary<int, string?>> GetEntityByIdAsync(

But those tests are for string? type. Do you mean specifically nullable struct and class types?

[svihpinc]

@michaelstaib added a test case for #8264 issue, also covers nullable class type

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (6a3b7a3) to head (89d9291).
Report is 68 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #8265       +/-   ##
==========================================
- Coverage   74.16%       0   -74.17%     
==========================================
  Files        2677       0     -2677     
  Lines      140790       0   -140790     
  Branches    16371       0    -16371     
==========================================
- Hits       104421       0   -104421     
+ Misses      30774       0    -30774     
+ Partials     5595       0     -5595     

Flag	Coverage Δ
unittests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.