ITP-JAN-LONDON|FOROGH AGHAEIYARIJANI|MODULE-DATA-FLOWS|SPRINT 1|DESTRUCTURING|problem-solving-destructuring #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forogh-Aghaeiyarijani
added
the
Needs Review
1 task
jenny-alexander
added
Review in progress
| // Task1: Display names of people in Gryffindor | ||
| console.log("Gryffindor Members:"); | ||
| hogwarts.forEach(({ firstName, lastName, house }) => { | ||
| if (house === "Gryffindor") { |
There was a problem hiding this comment.
Your code works well 👍
Non-blocking suggestion: If you wanted to improve clarity, you can use .filter to only include records where house === 'Gryffindor' before running .forEach.
|
|
||
| // Task2: Display names of teachers who have pets | ||
| console.log("\nTeachers with Pets:"); | ||
| hogwarts.forEach(({ firstName, lastName, occupation, pet }) => { |
There was a problem hiding this comment.
Your code works well 👍
Non-blocking suggestion: If you wanted to improve clarity, you can use .filter to only include records where occupation === 'Teacher' && pet before running .forEach.
jenny-alexander
approved these changes
Apr 20, 2025
jenny-alexander
added
Complete
|
Please make sure to update the Changelist section of the PR with a short explanation of your changes. |
jenny-alexander
added
Reviewed
Forogh-Aghaeiyarijani
added
the
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Implemented object destructuring in function parameters and within array iterations.
Added logic to:
Print names of Gryffindor members from the hogwarts array.
Print names of teachers with pets.
Generate a formatted receipt using object destructuring and computed totals.
Ensured output formatting matches the expected result for all tasks.
Questions
Ask any questions you have for your reviewer.