ITP London_Jan 2025 | Samunta Sunuwar Module-Data-Flows | Sprint 1|Array Destructuring #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samunta
commented
Apr 7, 2025
Samunta
commented
- I have committed my files one by one, on purpose, and for a reason
- I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
- I have tested my changes
- My changes follow the style guide
- My changes meet the requirements of this task
Samunta
added
📅 Data Flows
1 task
fearcyf
reviewed
Apr 10, 2025
There was a problem hiding this comment.
solution works in my IDE, what about adding the price currency and a comment line per code block to explain your thought process. Just suggestions.
There was a problem hiding this comment.
Thank you for the feedback, I will keep this in mind.
|
Solutions work as expected, just add a few comments to explain your code |
fearcyf
added
Reviewed
cjyuan
reviewed
Apr 10, 2025
| } | ||
| } | ||
| } | ||
| revelioGryffindor(hogwarts) |
There was a problem hiding this comment.
The function is not defined to accept any parameter though.
There was a problem hiding this comment.
Thank you for flagging this and pointing this out. I have now refactored my code and pushed commits to consider the missing parameter
Samunta
changed the title
Samunta
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.