ITP-Jan 2025 | London | Chi Mbah | Module-Data-Flows | Week 10 | Sprint 1 | Array Destructuring #191
Conversation
jenny-alexander
added
Review in progress
| console.log("QTY ITEM TOTAL"); | ||
|
|
||
| let total = 0; | ||
|
|
There was a problem hiding this comment.
It's best practice to declare variables that are not reassigned as 'const' instead of 'let'.
Can you review your variable declarations that are not reassigned and change them to const?
Here is a video you can watch: https://youtu.be/RE6qf3As-XU?si=_YaiEPeBC5Cx_j56
|
|
||
| console.log("Gryffindor Members:"); | ||
|
|
||
| hogwarts.forEach(({ firstName, lastName, house }) => { |
There was a problem hiding this comment.
This works really well! 👏
Something you can do (only a suggestion) is to use .filter to only keep the records where house === "Gryffindor", before .forEach.
This will make your code more concise.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/filter
(The same could be done to filter and only keep teachers who have pets in task 2 below)
jenny-alexander
added
Needs Review
|
Please make sure to update the Changelist section of the PR with a short explanation of your changes. |
jenny-alexander
added
Reviewed
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.