LONDON-JAN-25 | ANDREI FILIPPOV | Module-Data Flows | WEEK 3 feature/xkcd #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjyuan
reviewed
Apr 21, 2025
fetch/programmer-humour/fetch.js
Outdated
| @@ -0,0 +1,17 @@ | |||
| "use strict"; | |||
| const img = document.querySelector("img"); | |||
There was a problem hiding this comment.
It is a good practice to append a suffix like "Elem" to a name for variables that store a DOM element.
fetch/programmer-humour/index.html
Outdated
Comment on lines
11
to
12
| <div id="errorMessage"></div> | ||
| <img src="" /> |
There was a problem hiding this comment.
Why assign an id attribute to one of the elements but not the other?
There was a problem hiding this comment.
I did this because there’s only one image on the page, so I can select it by tag name. As for the div element, I wasn’t sure how many there might be in the future, so I decided to assign it an ID in advance.
cjyuan
added
Reviewed
Droid-An
added
the
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Done Programmer Humour application
Questions
no questions