Skip to content

ITP_Jan |Aung_Ye_Kyaw| Module-Data-Flows| library #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

sarawone
Copy link

@sarawone sarawone commented Apr 15, 2025

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Hi ,

Hope you are doing well!
I would like to thank you for reviewing my code.
Kindly check and provide feedback on it .

Thanks and Regards,
Aung Ye Kyaw

@sarawone sarawone added the Needs Review Participant to add when requesting review label Apr 15, 2025
@sarawone sarawone self-assigned this Apr 15, 2025
@cjyuan cjyuan added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Participant to add when requesting review labels Apr 17, 2025
Copy link

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://validator.w3.org/, there are errors in the index.html. Can you fix these errors?

The code works.

I think there are some improvements you can make.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Apr 17, 2025
@sarawone
Copy link
Author

According to https://validator.w3.org/, there are errors in the index.html. Can you fix these errors?

The code works.

I think there are some improvements you can make.

I have checked and fixed the errors. Kindly check and let me know.
If all codes are fine , please change the status (Complete ) or let me know for change.. Thank you so much .

@sarawone sarawone added the Needs Review Participant to add when requesting review label Apr 19, 2025
@cjyuan cjyuan added Complete Participant to add when work is complete and review comments have been addressed and removed Needs Review Participant to add when requesting review labels Apr 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complete Participant to add when work is complete and review comments have been addressed Reviewed Volunteer to add when completing a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants