ITP JAN 25 | Katarzyna Kazimierczuk | Data Flows | Programmer Humor #214
Conversation
jenny-alexander
added
Review in progress
There was a problem hiding this comment.
In the future, please make sure to test your changes before submitting! This is an important part of submitting a PR.
Currently your application does not return an image.
The fetch fails with message
Can you review the script you are referencing within index.html?
fetch/programmer-humour/styles.css
Outdated
| background-color: rgb(252, 254, 211); | ||
| } | ||
|
|
||
| #comic-container { |
There was a problem hiding this comment.
I don't see this styling (comic-container)being used in your application. If it's not being used, it's best to remove it. Or else, please review your index.html and make sure your div id names are correct.
jenny-alexander
added
Reviewed
Absolutely, it was a typo in the script link. |
katarzynakaz
added
the
Complete
jenny-alexander
removed
the
Complete
There was a problem hiding this comment.
@katarzynakaz - thanks for making those changes. This is much better!
I see you added 2 more files to the latest commit (package.json and package-lock.json). Please make sure to only commit the files necessary for the specific exercise.
Learners, PR Template
Self checklist
Changelist
Programmer humor task
Questions
No questions