PAWEL BROILO I MODULE DATA FLOWS I BOOK LIBRARY #220

PawelBroilo · 2025-04-23T13:58:55Z

Learners, PR Template

Self checklist

[x ] I have committed my files one by one, on purpose, and for a reason
[ x] I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
[x ] I have tested my changes
[x ] My changes follow the style guide
[x ] My changes meet the requirements of this task

Changelist

Briefly explain your PR.
I completed corrections for Book Library with Java Script. Files Index.html and script.js are included in Debugging/Book Library Folder in Book Library Project Folder.

Questions

Ask any questions you have for your reviewer.

cjyuan · 2025-04-23T14:17:23Z

Why did you close PR #218 and delete its branch?

My requests still stand:

You need to make changes in debugging/book-library
Your need to make changes to HTML code in index.html
You need to make changes to JavaScript code in script.js
You need to apply label to your PR properly to avoid delay in review
Do not create another PR

Please address these issues.

cjyuan · 2025-04-23T14:52:27Z

The code was not working when I tested them in the browser.

Did you forget to transfer the code from your implementation to these files?

cjyuan

Please transfer your code from Book Library.html to index.html and script.js.

cjyuan · 2025-04-23T14:48:08Z

debugging/book-library/index.html

Why yo deleted the <script> tag in this file that imports the code from script.js?

You have a working implementation in Book Library.html. You can transfer the HTML code (only HTML code) from that file to this file.

cjyuan · 2025-04-23T14:49:19Z

debugging/book-library/script.js

@@ -1,3 +1,4 @@
+<script>


This file should only contain JavaScript code.

cjyuan · 2025-04-23T14:50:33Z

debugging/book-library/script.js

The code in this script has bug and is not working properly. You will need to fix them.

Why don't you transfer your JS code from Book Library.html to this file?

cjyuan

You are getting closer. But you have to make some more changes to make the app work. Please refer to the feedback I left in your code.

cjyuan · 2025-04-23T16:00:33Z

debugging/book-library/index.html

If you don't add a proper <script> tag to include your code from script.js, the app won't work properly.

cjyuan · 2025-04-23T16:01:22Z

debugging/book-library/script.js

+          deleteCell.appendChild(delBtn);
+        });
+      }
+    </script>


Are <script> at line 1, and </script> at line 103 valid JS code?

cjyuan · 2025-04-23T17:19:44Z

You app still would not run. Your changes does not address my feedback. Please refer to my previous feedback left in your code.

PawelBroilo · 2025-04-23T17:39:11Z

Dear CJ, I tried to implement <script> and </script> elsewhere in order for it to work. Tried in Script.js in front and back of the code you provided in previous Comment however AI has placed it in corrected places in code Script.js and Book Library.html when I tested my code for <script> and </script>. I tested my implementation of <script> and </script> with AI for Book Library Project and now App runs correct with all its Buttons and Functions. However I am unsure if <script> and </script> are well positioned. CJ I will appreciate it if you post a Comment on what else I can do to improve a Code for Book Library Project for it to run correct.

…

On Wed, 23 Apr 2025, 18:20 CJ Yuan, ***@***.***> wrote: *cjyuan* left a comment (CodeYourFuture/Module-Data-Flows#220) <#220 (comment)> You app still would not run. Your changes does not address my feedback. Please refer to my previous feedback left in your code. — Reply to this email directly, view it on GitHub <#220 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVFFPRX3JAWDQ3UQW7WETST227DUNAVCNFSM6AAAAAB3WODPXSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMRVGAYDGOBXGA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

cjyuan · 2025-04-23T17:48:10Z

I left you two specific comments:

In your index.html: If you don't add a proper <script> tag to include your code from script.js, the app won't work properly.
In your script.js, are <script> at line 1, and </script> at line 104 valid JS code?

Which part of the comment do you not understand?

cjyuan · 2025-04-23T17:49:59Z

Don't update Book Library.html. Make change in index.html and script.js.

PawelBroilo · 2025-04-23T18:04:34Z

Dear CJ, I am not sure where to place additional <script> tag for Script.js for a Book Library App to work properly. In my script.js it seems like <script> and </script> are generating an error when positioned on lines 1 and 104 althought AI test suggest otherwise and places them on lines 1 and 104. I can't see where am I making an error with <script> tag. It seems like I keep overlooking it. Its why I run AI test which opens an App. The code itself still doesn't have <script> in correct place its just myself I don't know where to implement. Perhaps I didn't get the first part of your Comment correct as I explained the second part with lines 1 and 104. CJ can you suggest anything so I can complete Step 4 with your Comment.

…

On Wed, 23 Apr 2025, 18:50 CJ Yuan, ***@***.***> wrote: *cjyuan* left a comment (CodeYourFuture/Module-Data-Flows#220) <#220 (comment)> Don't update Book Library.html. Make change in index.html and script.js. — Reply to this email directly, view it on GitHub <#220 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVFFPRXNC6QCCXKZCZWHO6D227HFZAVCNFSM6AAAAAB3WODPXSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMRVGA3TIOBQGA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

cjyuan · 2025-04-23T18:09:15Z

How do we include JS code in a file named script.js into a HTML file?

Feed your JS code to ChatGPT to see if ChatGPT can point out the error in your code.

cjyuan · 2025-04-23T18:21:06Z

You only need to delete 2 lines of code from script.js for it to work. (You deleted the wrong code)

You only need to add one tag to index.html for it to work.

PawelBroilo · 2025-04-23T18:28:42Z

Dear CJ, I tested Script.js with Chat GPT like you suggested for me to test my Script.js ChatGPT corrected one line and displayed a fixed version of Script.js I included this version of Script.js in GitHub Pull Request #220. Now I will do same with Index.html I will test it with Chat GPT to find corrected code for Index.html and I will post it on GitHub Pull Request #220. Kind Regards, Pawel Broilo

…

On Wed, 23 Apr 2025 at 19:21, CJ Yuan ***@***.***> wrote: *cjyuan* left a comment (CodeYourFuture/Module-Data-Flows#220) <#220 (comment)> You only need to delete 2 lines of code from script.js for it to work. (You deleted the wrong code) You only need to add one tag to index.html for it to work. — Reply to this email directly, view it on GitHub <#220 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVFFPRRJWDYY244PM3EJGDT227K2RAVCNFSM6AAAAAB3WODPXSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMRVGE2DINBXGM> . You are receiving this because you authored the thread.Message ID: ***@***.***>

cjyuan · 2025-04-23T18:31:54Z

Well, can you delete "<script>" and "</script>" from script.js?

Then next you will just need to include JS code to your HTML using a <script src="..."> tag.

PawelBroilo · 2025-04-23T18:45:18Z

Hi CJ, I just deleted both <script> and </script> from script.js I included external File Script.js in HTML. I hope its sufficient for Code Your Future. Kind Regards, Pawel Broilo

…

On Wed, 23 Apr 2025, 19:32 CJ Yuan, ***@***.***> wrote: *cjyuan* left a comment (CodeYourFuture/Module-Data-Flows#220) <#220 (comment)> Well, can you delete "<script>" and "</script>" from script.js? Then next you will just need to include JS code to your HTML using a <script src="..."> tag. — Reply to this email directly, view it on GitHub <#220 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVFFPRWMA2NLIRI77XLCLM3227MC7AVCNFSM6AAAAAB3WODPXSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMRVGE3DONZYGQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

PawelBroilo and others added 3 commits April 21, 2025 19:12

Add files via upload

818db8c

Test

66d2611

Test

ca17df7

cjyuan added the Reviewed Volunteer to add when completing a review label Apr 23, 2025

PawelBroilo added the Complete Participant to add when work is complete and review comments have been addressed label Apr 23, 2025

PawelBroilo added 2 commits April 23, 2025 15:33

Update index.html

fc43ad7

Update script.js

0a55d58

cjyuan reviewed Apr 23, 2025

View reviewed changes

cjyuan removed the Complete Participant to add when work is complete and review comments have been addressed label Apr 23, 2025

PawelBroilo added 6 commits April 23, 2025 16:07

Update index.html

2efaeff

Update Book Library.html

663d5f3

Update script.js

f2ca7b5

Update Book Library.html

f395310

Update script.js

c54024d

Update Book Library.html

2b015d1

cjyuan reviewed Apr 23, 2025

View reviewed changes

PawelBroilo added 3 commits April 23, 2025 17:48

Update script.js

13414c9

Update index.html

57d732c

Update Book Library.html

aa16a36

Update Book Library.html

82a7b01

Update Book Library.html

4d22e09

Update script.js

008b991

Update Book Library.html

85ca2fa

PawelBroilo added 2 commits April 23, 2025 19:34

Update script.js

080663d

Update index.html

4048c4a

PawelBroilo added the Complete Participant to add when work is complete and review comments have been addressed label Apr 23, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PAWEL BROILO I MODULE DATA FLOWS I BOOK LIBRARY #220

PAWEL BROILO I MODULE DATA FLOWS I BOOK LIBRARY #220

PawelBroilo commented Apr 23, 2025

cjyuan commented Apr 23, 2025

cjyuan commented Apr 23, 2025

cjyuan left a comment

cjyuan Apr 23, 2025

cjyuan Apr 23, 2025

cjyuan Apr 23, 2025

cjyuan left a comment

cjyuan Apr 23, 2025

cjyuan Apr 23, 2025

cjyuan commented Apr 23, 2025

PawelBroilo commented Apr 23, 2025 via email

cjyuan commented Apr 23, 2025

cjyuan commented Apr 23, 2025

PawelBroilo commented Apr 23, 2025 via email

cjyuan commented Apr 23, 2025

cjyuan commented Apr 23, 2025

PawelBroilo commented Apr 23, 2025 via email

cjyuan commented Apr 23, 2025

PawelBroilo commented Apr 23, 2025 via email

PAWEL BROILO I MODULE DATA FLOWS I BOOK LIBRARY #220

Are you sure you want to change the base?

PAWEL BROILO I MODULE DATA FLOWS I BOOK LIBRARY #220

Conversation

PawelBroilo commented Apr 23, 2025

Learners, PR Template

Changelist

Questions

cjyuan commented Apr 23, 2025

cjyuan commented Apr 23, 2025

cjyuan left a comment

Choose a reason for hiding this comment

cjyuan Apr 23, 2025

Choose a reason for hiding this comment

cjyuan Apr 23, 2025

Choose a reason for hiding this comment

cjyuan Apr 23, 2025

Choose a reason for hiding this comment

cjyuan left a comment

Choose a reason for hiding this comment

cjyuan Apr 23, 2025

Choose a reason for hiding this comment

cjyuan Apr 23, 2025

Choose a reason for hiding this comment

cjyuan commented Apr 23, 2025

PawelBroilo commented Apr 23, 2025 via email

cjyuan commented Apr 23, 2025

cjyuan commented Apr 23, 2025

PawelBroilo commented Apr 23, 2025 via email

cjyuan commented Apr 23, 2025

cjyuan commented Apr 23, 2025

PawelBroilo commented Apr 23, 2025 via email

cjyuan commented Apr 23, 2025

PawelBroilo commented Apr 23, 2025 via email