Skip to content

London|Haftamu Kebedew|Module-Data-Groups|Sprint 2|Exercise 2|Week 2 #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

London|Haftamu Kebedew|Module-Data-Groups|Sprint 2|Exercise 2|Week 2 #127

wants to merge 25 commits into from

Conversation

HaftamuKebedew
Copy link

@HaftamuKebedew HaftamuKebedew commented Dec 7, 2024 •
edited
Loading

London | Haftamu Kebedew | Module-DAta-Groups|Sprint 2|Exercise 2| WEEK 2

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@HaftamuKebedew
median files updated by fixing the implementation calculaltion
2b6a100
@HaftamuKebedew
dedupe file updated
1dbc52c
@HaftamuKebedew
max file updated
4ac85d1
@HaftamuKebedew
sum function defined
f33a91d
@HaftamuKebedew
sum test case defined
dc22dd0
@HaftamuKebedew
for loop refactored
3ee4cb2
@HaftamuKebedew
calculatedFrequency function defined to import an input from input.tx…
42ee168 
…t file
@HaftamuKebedew
accessing houseNumber value updated
2018f5d
@HaftamuKebedew
for loop updated form of to in and accessed using their key when they…
8466b0e 
… itreate
@HaftamuKebedew
explanation added in address file
ccf47b2
@HaftamuKebedew
some predict and explanation added in author file
7e850d0
@HaftamuKebedew
recipe object of ingredients key value accessing way updated
3465d4f
@HaftamuKebedew
containes file functions modified
c1a784b
@HaftamuKebedew
contains test case defined
d6193f6
@HaftamuKebedew
lookup function updated
3c0bb1a
@HaftamuKebedew
one lookup taste case defined
c952987
@HaftamuKebedew
test case added
5240f46
@HaftamuKebedew
more test case added
2433669
@HaftamuKebedew
total function modified
d4a8b8b
@HaftamuKebedew
more test case given
72196ca
@HaftamuKebedew
invert function defined and new invert test function created
d843fed
@HaftamuKebedew
more test cases of invert defined
d898e3a
@HaftamuKebedew
count words function defined
b984ad0
@HaftamuKebedew
countFrequencies and findMode defined in mode files and invoked in th…
9dda208 
…e function calculatedMode
@HaftamuKebedew
till function and test updated
4e2162f
@HaftamuKebedew HaftamuKebedew added the Needs Review Participant to add when requesting review label Dec 7, 2024
@cjyuan cjyuan added the 👀 Review Git Changes requested to do with Git label Dec 15, 2024
@cjyuan
Copy link
Contributor

cjyuan commented Dec 15, 2024

The current branch contains also modified files in Sprint-1 folder.
Can you rebase your Sprint-2 branch onto main so that it only contains modified files in the Sprint-2 folder?

@illicitonion illicitonion removed the Needs Review Participant to add when requesting review label Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
👀 Review Git Changes requested to do with Git
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HaftamuKebedew @cjyuan @illicitonion