CYF Glasgow | Iakub Dubachev | Module-Data-Groups | Quote Generator | WEEK 3

[IakubDubachev]

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist
This PR improves the reliability and clarity of the quote generator tests. Key updates include:

Async userEvent.click Integration: Ensured userEvent.click is properly awaited to avoid race conditions.

Element Existence Checks: Added explicit checks to confirm the presence of the #new-quote button before interaction.

Improved Cleanup: Used jest.clearAllMocks alongside jest.restoreAllMocks in the afterEach hook to prevent cross-test contamination.

Error Handling in beforeEach: Added error handling during JSDOM.fromFile initialization to log potential setup failures.

Assertion Consistency: Ensured predictable quote and author assertions based on mocked Math.random values.

Questions

Are there any additional edge cases you’d suggest covering in these tests?

Does the error handling during JSDOM initialization align with our project's testing standards?

Would you recommend further improvements to the structure or clarity of these tests?

[halilibrahimcelik]

I'm getting this error. Keep in mind that while defining constants and static data, you should always define them at the top level.
JavaScript reads and executes scripts from top to bottom. If you declare and initialize a variable or constant at the bottom of your script but reference it earlier, the browser encounters the reference before the variable is initialized, leading to this error.

[halilibrahimcelik]

Also make sure you passed all tests before creating a PR.

[halilibrahimcelik]

Lastly, although it is not the primary focus of this project, enhancing the display of quotes with some styling would be a valuable addition. This improvement would not only make the presentation more visually appealing but also provide an opportunity to gain more experience with CSS and user interface design.