Skip to content

London | Phone_Naing | Module-Data-Groups| WEEK3SLideShow #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

London | Phone_Naing | Module-Data-Groups| WEEK3SLideShow #255

wants to merge 6 commits into from

Conversation

Mgphone
Copy link

@Mgphone Mgphone commented Dec 28, 2024 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@Mgphone Mgphone added the Needs Review Participant to add when requesting review label Dec 28, 2024
@cjyuan cjyuan added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Jan 12, 2025
cjyuan
cjyuan reviewed Jan 12, 2025
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch contains modified files that are not related to the "Slide Show" app, making reviewing changed files inconvenient. Can you try making this branch cleaner?

@cjyuan cjyuan added 👀 Review Git Changes requested to do with Git and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jan 12, 2025
@tyzia
Copy link
Contributor

tyzia commented Jan 18, 2025

I don't see any updates on this PR for a while. Please, add label 'Needs review' once it is updated.

@tyzia tyzia added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
👀 Review Git Changes requested to do with Git Reviewed Volunteer to add when completing a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mgphone @tyzia @cjyuan