London | Nadarajah_Sripathmanathan | Sprint-2 | Week3 #466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dear admin , I have done step 3 sprint -2 . could you review please |
cjyuan
reviewed
Apr 7, 2025
Comment on lines
+2
to
23
| function createLookup(items, keySelector, valueSelector) { | ||
| if (!Array.isArray(items)) { | ||
| return {}; | ||
| } | ||
|
|
||
| if (typeof keySelector !== 'function' || typeof valueSelector !== 'function') { | ||
| throw new Error('keySelector and valueSelector must be functions'); | ||
| } | ||
|
|
||
| const lookup = {}; | ||
|
|
||
| for (const item of items) { | ||
| const key = keySelector(item); | ||
| const value = valueSelector(item); | ||
|
|
||
| if (key !== undefined) { | ||
| lookup[key] = value; | ||
| } | ||
| } | ||
|
|
||
| return lookup; | ||
| } |
There was a problem hiding this comment.
- Why not just accept two strings as the 2nd and 3rd parameters and write lines 14-15 as
const key = item[keySelector]
const value = item[valueSelector]
?
| const decodedKey = decodeURIComponent(key.replace(/\+/g, " ")); | ||
|
|
||
| // Decode value, but do not replace "+" with spaces | ||
| const decodedValue = value ? decodeURIComponent(value) : null; |
There was a problem hiding this comment.
What's your rationale behind not treating + in the value as space?
cjyuan
added
Reviewed
|
Can you fix this branch so that it does not contain any modified files in the Sprint-1 folder? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.