-
-
Notifications
You must be signed in to change notification settings - Fork 94
WESTMIDLANDS JAN ITP|SEGUN FOLAYAN|DATA-GROUPS|SPRINT-2 #475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Sprint-2/implement/querystring.js
Outdated
@@ -6,8 +6,10 @@ function parseQueryString(queryString) { | |||
const keyValuePairs = queryString.split("&"); | |||
|
|||
for (const pair of keyValuePairs) { | |||
const [key, value] = pair.split("="); | |||
queryParams[key] = value; | |||
const [key, ...value] = pair.split("="); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
In the real world, URLs are usually encoded with percent encoding to represent special characters. In URL, & can be used as a separator (key=value&key=value...) or special character within a key or value. if we were to use & as a special character, we need to encode it.
Can you refactor the code so that parseQueryString("a%25b=c%26d") results in { "a%b": "c&d" }?
FYI, %25 is same as %, %26 is same as &
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
function parseQueryString(queryString) {
const queryParams = {};
if (queryString.length === 0) {
return queryParams;
}
const keyValuePairs = queryString.split("&");
for (const pair of keyValuePairs) {
const decodedPair = decodeURIComponent(pair);
const [key, ...value] = decodedPair.split("=");
const newValue = value.join("=");
// Store the decoded key and value in the queryParams object
queryParams[key] = newValue;
}
return queryParams;
}
module.exports = parseQueryString;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.