WESTMIDLANDS-JAN-ITP|SEGUN FOLAYAN|DATA GROUPS|SPRINT3-QUOTE GENERATOR #489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjyuan
reviewed
Apr 8, 2025
Comment on lines
+494
to
+496
| const Quote = document.getElementById("quote"); | ||
| const Author = document.getElementById("author"); | ||
| const NewQuote = document.getElementById("new-quote"); |
There was a problem hiding this comment.
Normal convention is to start a variable name with a lowercase letter. Names that begin with an uppercase letter are typically given to User-defined Type/Class in JS.
To make variable names (for storing DOM objects) more meaningful, a better practice is to add a suffix to the variable names. For examples, quoteEl, authorEl, newQuoteButton.
cjyuan
added
Reviewed
segunfolayan
added
the
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
QUOTE GENERATOR
Questions
Ask any questions you have for your reviewer.