WESTMIDLANDS-ITP|SEGUN FOLAYAN|DATA-GROUPS|ALARMCLOCK #493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjyuan
added
the
Review in progress
cjyuan
reviewed
Apr 13, 2025
There was a problem hiding this comment.
You missed updating index.html according to an instruction in readme.md.
When the user clicks "Stop Alarm", the background is not reset to its initial color.
Otherwise, the code is working good.
Feel free to mark this PR as "Complete" after you have made the necessary changes based on my feedback.
Sprint-3/alarmclock/alarmclock.js
Outdated
Comment on lines
14
to
17
| if (isNaN(timeLeft) || timeLeft < 0) { | ||
| alert("Please enter a valid positive number for the alarm time (in seconds)."); | ||
| return; | ||
| } |
There was a problem hiding this comment.
0 is not a positive number.
There was a problem hiding this comment.
I will update with corrections. Thanks.
cjyuan
added
Reviewed
segunfolayan
added
the
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
PR for Sprint-3 Alarm Clock
Questions
Ask any questions you have for your reviewer.